Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3830)

Unified Diff: chrome/browser/ui/views/window.cc

Issue 8604012: move chromeos bubble setup code to window.cc (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: use chrome/browser/uil/views/window.cc Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/window.cc
diff --git a/chrome/browser/ui/views/window.cc b/chrome/browser/ui/views/window.cc
index 6199ecfbc9eb45bf62703317937615c36d8d1c1e..d3d4aa91848b7ea791bee63245d9568186db4303 100644
--- a/chrome/browser/ui/views/window.cc
+++ b/chrome/browser/ui/views/window.cc
@@ -4,11 +4,14 @@
#include "chrome/browser/ui/views/window.h"
+#include "ui/views/bubble/bubble_delegate.h"
#include "views/widget/widget.h"
#if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
#include "chrome/browser/chromeos/frame/bubble_window.h"
-#endif // defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/legacy_window_manager/wm_ipc.h"
+#include "third_party/cros_system_api/window_manager/chromeos_wm_ipc_enums.h"
+#endif
namespace browser {
@@ -24,4 +27,20 @@ views::Widget* CreateViewsWindow(gfx::NativeWindow parent,
#endif
}
+views::Widget* CreateViewsBubble(views::BubbleDelegateView* delegate) {
Daniel Erat 2011/11/21 23:10:50 nit: one space after return type instead of two
alicet1 2011/11/22 00:23:53 Done.
+ views::Widget* bubble_widget =
+ views::BubbleDelegateView::CreateBubble(delegate);
+#if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
+ {
+ std::vector<int> params;
+ params.push_back(delegate->show_while_screen_is_locked());
+ chromeos::WmIpc::instance()->SetWindowType(
+ bubble_widget->GetNativeView(),
+ chromeos::WM_IPC_WINDOW_CHROME_INFO_BUBBLE,
+ &params);
+ }
+#endif
+ return bubble_widget;
+}
+
} // namespace browser

Powered by Google App Engine
This is Rietveld 408576698