Issue 8588046: nacl_helper_bootstrap: Reserve correct address space size for ARM, none for x86-64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8588046: nacl_helper_bootstrap: Reserve correct address space size for ARM, none for x86-64 (Closed)

Created:
9 years, 1 month ago by Roland McGrath

Modified:
9 years, 1 month ago

Reviewers:
Mark Seaborn, Brad Chen

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

nacl_helper_bootstrap: Reserve correct address space size for ARM, none for x86-64 The address space reservation has only been thoroughly used and tested on x86-32. It's also necessary on ARM, but it needs a different exact amount reserved. For x86-64, the reserved space is not used, so it's a waste of address space to consume a gigabyte for it. BUG= none TEST= nacl_integration R=mseaborn@chromium.org,bradchen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110739

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -13 lines)			Patch
	M	chrome/nacl.gypi	View		3 chunks	+32 lines, -8 lines	1 comment	Download
	M	chrome/nacl/nacl_helper_bootstrap_linux.x	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

9 years, 1 month ago (2011-11-18 00:31:03 UTC) #2

LGTM

http://codereview.chromium.org/8588046/diff/1/chrome/nacl.gypi
File chrome/nacl.gypi (right):

http://codereview.chromium.org/8588046/diff/1/chrome/nacl.gypi#newcode147
chrome/nacl.gypi:147: 'nacl_reserve_top': ['--defsym',
'RESERVE_TOP=0x40001000'],
As an aside, do we cross-check this?  If I lower either of these two values,
does it cause a test to fail?  Does the size get passed through at runtime?

Expand Messages | Collapse Messages