Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4402)

Unified Diff: chrome/nacl/nacl_helper_bootstrap_linux.x

Issue 8588046: nacl_helper_bootstrap: Reserve correct address space size for ARM, none for x86-64 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/nacl.gypi ('K') | « chrome/nacl.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/nacl/nacl_helper_bootstrap_linux.x
diff --git a/chrome/nacl/nacl_helper_bootstrap_linux.x b/chrome/nacl/nacl_helper_bootstrap_linux.x
index 3f93a0024403e8b21be832b203b360c4c5a6dd80..89acd90309320f449dab83de313b189975de3508 100644
--- a/chrome/nacl/nacl_helper_bootstrap_linux.x
+++ b/chrome/nacl/nacl_helper_bootstrap_linux.x
@@ -33,11 +33,11 @@ ENTRY(_start)
TEXT_START = 0x10000;
/*
- * This is the top of the range we are trying to reserve, which is 1G
- * for x86-32 and ARM. For an x86-64 zero-based sandbox, this really
- * needs to be 36G.
+ * The symbol RESERVE_TOP is the top of the range we are trying to reserve.
+ * This is set via --defsym on the linker command line, because the correct
+ * value differs for each machine. It's not defined at all if we do not
+ * actually need any space reserved for this configuration.
*/
-RESERVE_TOP = 1 << 30;
/*
* We specify the program headers we want explicitly, to get the layout
@@ -109,7 +109,7 @@ SECTIONS {
. = ALIGN(CONSTANT(COMMONPAGESIZE));
RESERVE_START = .;
.reserve : {
- . = RESERVE_TOP - RESERVE_START;
+ . += DEFINED(RESERVE_TOP) ? (RESERVE_TOP - RESERVE_START) : 0;
} :reserve
/*
« chrome/nacl.gypi ('K') | « chrome/nacl.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698