Issue 8585007: Added hotkey support to 8508009

Issue 8585007: Added hotkey support to 8508009 (Closed)

Created:
9 years, 1 month ago by pkotwicz

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, dhollowa, tfarina, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added hotkey support to 8508009 Alt-L (print layer tree) Added name in RenderWidgetHostViewAura Made Window::SetName update the layer name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112232 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112528

Patch Set 2 : Changed SetName to get additional debugging output #

Patch Set 4 : Fixed compile issue #

Total comments: 1

Patch Set 5 : for try bots #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -27 lines)			Patch
M	chrome/browser/chromeos/login/webui_login_display_host.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/aura/status_area_host_aura.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1 2 3 4	3 chunks	+3 lines, -0 lines	0 comments	Download
M	ui/aura/desktop.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window.h	View	1 2 3 4	2 chunks	+4 lines, -1 line	0 comments	Download
M	ui/aura/window.cc	View	1 2 3 4	3 chunks	+25 lines, -13 lines	0 comments	Download
M	ui/aura_shell/desktop_background_view.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/examples/lock_view.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/examples/toplevel_window.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/examples/widgets.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/examples/window_type_launcher.cc	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/modal_container_layout_manager.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/shell_accelerator_controller.cc	View	1 2 3 4	3 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/aura_shell/status_area_view.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/8585007/diff/3018/ui/aura/desktop.cc File ui/aura/desktop.cc (right): http://codereview.chromium.org/8585007/diff/3018/ui/aura/desktop.cc#newcode142 ui/aura/desktop.cc:142: bool MaybePrintDebug(Desktop* desktop, KeyEvent* event) { Can you ...

9 years, 1 month ago (2011-11-17 21:03:16 UTC) #2

Ben Goodger (Google)

I think mazda is landed (for over a week now)... are you going to check ...

9 years ago (2011-11-30 16:01:44 UTC) #3

In now =]

Expand Messages | Collapse Messages