Issue 858008: VBoot Reference: Fix many memory leaks.

Issue 858008: VBoot Reference: Fix many memory leaks. (Closed)

Created:
10 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Luigi Semenzato, sosa

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

VBoot Reference: Fix many memory leaks. Fix memory leaks found using Valgrind, adds sanity checking to RSAPublicKey parsing code to prevent crazy behavior.

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -25 lines)			Patch
M	src/platform/vboot_reference/crypto/rsa_utility.c	View	3 chunks	+19 lines, -5 lines	0 comments	Download
M	src/platform/vboot_reference/include/rsa_utility.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/tests/firmware_image_tests.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/tests/kernel_image_tests.c	View	1 chunk	+1 line, -1 line	2 comments	Download
M	src/platform/vboot_reference/tests/rsa_padding_test.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform/vboot_reference/tests/rsa_verify_benchmark.c	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/firmware_image.c	View	4 chunks	+14 lines, -9 lines	0 comments	Download
M	src/platform/vboot_reference/utils/kernel_image.c	View	6 chunks	+14 lines, -7 lines	0 comments	Download
M	src/platform/vboot_reference/utils/signature_digest.c	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

gauravsh

Adding Luigi too since I have another change pending in the pipeline.

10 years, 9 months ago (2010-03-13 01:02:19 UTC) #2

Luigi Semenzato

Looks Good To Me http://codereview.chromium.org/858008/diff/1/5 File src/platform/vboot_reference/tests/kernel_image_tests.c (right): http://codereview.chromium.org/858008/diff/1/5#newcode238 src/platform/vboot_reference/tests/kernel_image_tests.c:238: failure: Nit: I wouldn't call ...

10 years, 9 months ago (2010-03-13 01:21:09 UTC) #3

sosa

Sorry I missed this, do you need another lgtm from me? On Fri, Mar 12, ...

10 years, 9 months ago (2010-03-13 01:28:07 UTC) #4

gauravsh

On Fri, Mar 12, 2010 at 5:28 PM, Chris Sosa <sosa@chromium.org> wrote: > Sorry I ...

10 years, 9 months ago (2010-03-13 01:34:39 UTC) #5

gauravsh

10 years, 9 months ago (2010-03-13 01:36:39 UTC) #6

http://codereview.chromium.org/858008/diff/1/5
File src/platform/vboot_reference/tests/kernel_image_tests.c (right):

http://codereview.chromium.org/858008/diff/1/5#newcode238
src/platform/vboot_reference/tests/kernel_image_tests.c:238: failure:
On 2010/03/13 01:21:09, Luigi Semenzato wrote:
> Nit: I wouldn't call this "failure" since you go through here also on success.

> More like "cleanup".  (Not really part of the review.)

Yeah. I might change this at some point. I might just get rid of all the gotos,
so not changing it right now.

Expand Messages | Collapse Messages