VBoot Reference: Fix many memory leaks.

src/platform/vboot_reference/tests/kernel_image_tests.c

 /* Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  *
  * Tests for kernel image library.
  */
 
 #include <stdio.h>
 #include <stdlib.h>
 
@@ skipping 217 matching lines @@
   /* Test Kernel blob verify operations. */
   if (!VerifyKernelTest(kernel_blob, firmware_key_blob))
     error_code = 255;
 
   /* Test KernelImage verify operations. */
   if (!VerifyKernelImageTest(image, firmware_key))
     error_code = 255;
   if (!VerifyKernelImageTamperTest(image, firmware_key))
     error_code = 255;
 
 failure:

[Luigi Semenzato, 2010/03/13 01:21:09]

Nit: I wouldn't call this "failure" since you go through here also on success. 
More like "cleanup".  (Not really part of the review.)

[gauravsh, 2010/03/13 01:36:39]

Yeah. I might change this at some point. I might just get rid of all the gotos,
so not changing it right now.

   Free(kernel_blob);
   KernelImageFree(image);
   Free(kernel_sign_key_buf);
   Free(firmware_key_blob);
-  Free(firmware_key);
+  RSAPublicKeyFree(firmware_key);
 
   return error_code;
 }