Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 8575019: Revert 110934 - Retry of http://codereview.chromium.org/8589029. (Closed)

Created:
9 years, 1 month ago by Sigurður Ásgeirsson
Modified:
9 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 110934 - Retry of http://codereview.chromium.org/8589029. Start of mini_installer build config refactoring. Baby step one: - All intermediate files go into the intermediate directory. - The packed_files.txt file is gone, and instead the mini_installer is baked from a resource file output into the intermediate dir. - Cleanup use of implict global "options" in the python script. - Use subprocess.call with a list instead of os.system. R=robertshield@chromium.org,grt@chromium.org BUG=102115 Review URL: http://codereview.chromium.org/8600008 TBR=siggi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -154 lines) Patch
M chrome/installer/mini_installer.gyp View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.rc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer_exe_version.rc.version View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/create_installer_archive.py View 12 chunks +116 lines, -147 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sigurður Ásgeirsson
9 years, 1 month ago (2011-11-21 16:28:02 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698