Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 8600008: Retry of http://codereview.chromium.org/8589029. (Closed)

Created:
9 years, 1 month ago by Sigurður Ásgeirsson
Modified:
9 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Retry of http://codereview.chromium.org/8589029. Start of mini_installer build config refactoring. Baby step one: - All intermediate files go into the intermediate directory. - The packed_files.txt file is gone, and instead the mini_installer is baked from a resource file output into the intermediate dir. - Cleanup use of implict global "options" in the python script. - Use subprocess.call with a list instead of os.system. R=robertshield@chromium.org,grt@chromium.org BUG=102115 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110934

Patch Set 1 #

Patch Set 2 : And now actually works. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -142 lines) Patch
M chrome/installer/mini_installer.gyp View 1 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.rc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer_exe_version.rc.version View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/create_installer_archive.py View 12 chunks +148 lines, -117 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sigurður Ásgeirsson
PTAL - turns out for whatever reason the .rc file output the .release rule will ...
9 years, 1 month ago (2011-11-19 00:34:06 UTC) #1
robertshield
lgtm
9 years, 1 month ago (2011-11-21 14:28:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/8600008/2001
9 years, 1 month ago (2011-11-21 14:29:13 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 16:08:00 UTC) #4
Change committed as 110934

Powered by Google App Engine
This is Rietveld 408576698