Start of mini_installer build config refactoring.

Start of mini_installer build config refactoring.
Baby step one: 
- All intermediate files go into the intermediate directory.
- The packed_files.txt file is gone, and instead the mini_installer
  is baked from a resource file output into the intermediate dir.
- Cleanup use of implict global "options" in the python script.
- Use subprocess.call with a list instead of os.system.

R=robertshield@chromium.org,grt@chromium.org
BUG=102115
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110703

[robertshield, 2011-11-17 20:19:08]

LGTM, modulo the version resource thing.

http://codereview.chromium.org/8589029/diff/1/chrome/installer/mini_installer...
File chrome/installer/mini_installer/mini_installer.rc (left):

http://codereview.chromium.org/8589029/diff/1/chrome/installer/mini_installer...
chrome/installer/mini_installer/mini_installer.rc:54: "#include
""mini_installer_exe_version.rc""\r\0"
There needs to be a version resource somewhere in mini_installer.

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
File chrome/tools/build/win/create_installer_archive.py (left):

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:109: def
IsChromeFrameFile(file):
Thanks for deleting this :)

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
File chrome/tools/build/win/create_installer_archive.py (right):

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:297: os.path.join(build_dir,
setup_file).replace("\\","/"),
replace() -> os.path.normpath()?

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:300: os.path.join(build_dir,
archive_file).replace("\\","/"),
ditto

[grt (UTC plus 2), 2011-11-17 20:28:14]

lg

http://codereview.chromium.org/8589029/diff/1/chrome/installer/mini_installer...
File chrome/installer/mini_installer/mini_installer.rc (left):

http://codereview.chromium.org/8589029/diff/1/chrome/installer/mini_installer...
chrome/installer/mini_installer/mini_installer.rc:54: "#include
""mini_installer_exe_version.rc""\r\0"
On 2011/11/17 20:19:08, robertshield wrote:
> There needs to be a version resource somewhere in mini_installer.

mini_installer_exe_version.rc is being compiled in independently.  siggi: edit
that file and change VS_VERSION_INFO to 1.  robert made a corresponding change
to many other version resources some time ago.  then verify that once you build
the mini_installer, it has one and only one version resource.

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
File chrome/tools/build/win/create_installer_archive.py (right):

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:86: input_file]
some (but not all) of these lists you've added have a trailing comma.  please
pick one style and stick with it.

[Sigurður Ásgeirsson, 2011-11-17 22:14:46]

Thanks. I have verified that mini_installer has precisely one, valid VERSION
resource with this change. 
PTA(quick)L?

http://codereview.chromium.org/8589029/diff/1/chrome/installer/mini_installer...
File chrome/installer/mini_installer/mini_installer.rc (left):

http://codereview.chromium.org/8589029/diff/1/chrome/installer/mini_installer...
chrome/installer/mini_installer/mini_installer.rc:54: "#include
""mini_installer_exe_version.rc""\r\0"
On 2011/11/17 20:19:08, robertshield wrote:
> There needs to be a version resource somewhere in mini_installer.

Done.

http://codereview.chromium.org/8589029/diff/1/chrome/installer/mini_installer...
chrome/installer/mini_installer/mini_installer.rc:54: "#include
""mini_installer_exe_version.rc""\r\0"
On 2011/11/17 20:28:14, grt wrote:
> On 2011/11/17 20:19:08, robertshield wrote:
> > There needs to be a version resource somewhere in mini_installer.
> 
> mini_installer_exe_version.rc is being compiled in independently.  siggi: edit
> that file and change VS_VERSION_INFO to 1.  robert made a corresponding change
> to many other version resources some time ago.  then verify that once you
build
> the mini_installer, it has one and only one version resource.

Done.

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
File chrome/tools/build/win/create_installer_archive.py (left):

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:109: def
IsChromeFrameFile(file):
On 2011/11/17 20:19:08, robertshield wrote:
> Thanks for deleting this :)

NP.

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
File chrome/tools/build/win/create_installer_archive.py (right):

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:86: input_file]
On 2011/11/17 20:28:14, grt wrote:
> some (but not all) of these lists you've added have a trailing comma.  please
> pick one style and stick with it.

Done.

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:297: os.path.join(build_dir,
setup_file).replace("\\","/"),
On 2011/11/17 20:19:08, robertshield wrote:
> replace() -> os.path.normpath()?

I think forward slashes are wanted here because backslashes will need doubling
up as RC.exe wants to treat them as escape sequences.

http://codereview.chromium.org/8589029/diff/1/chrome/tools/build/win/create_i...
chrome/tools/build/win/create_installer_archive.py:300: os.path.join(build_dir,
archive_file).replace("\\","/"),
On 2011/11/17 20:19:08, robertshield wrote:
> ditto

ditto

[robertshield, 2011-11-17 22:26:04]

lgtm

[grt (UTC plus 2), 2011-11-17 23:09:08]

lgtm, but the builder disagrees

[Sigurður Ásgeirsson, 2011-11-18 13:51:48]

Thanks, the output from the build rule was mis-specified. Hopefully fixed now,
re-trying.

[commit-bot: I haz the power, 2011-11-18 14:55:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/siggi@chromium.org/8589029/14003

[commit-bot: I haz the power, 2011-11-18 15:56:46]

Change committed as 110703