Sync Promo: Add more UMA metrics.

chrome/browser/ui/webui/sync_promo_handler.h

Index: chrome/browser/ui/webui/sync_promo_handler.h
diff --git a/chrome/browser/ui/webui/sync_promo_handler.h b/chrome/browser/ui/webui/sync_promo_handler.h
index fa792858779aaeb4578d0f59dc7a179100be41e2..1db1969e74b9e973d20936f8899b96e7f77f2156 100644
--- a/chrome/browser/ui/webui/sync_promo_handler.h
+++ b/chrome/browser/ui/webui/sync_promo_handler.h
@@ -10,7 +10,7 @@
 
 class PrefService;
 
-// The handler for Javascript messages related to the "sync promo" page.
+// The handler for JavaScript messages related to the "sync promo" page.
 class SyncPromoHandler : public SyncSetupHandler {
  public:
   explicit SyncPromoHandler(ProfileManager* profile_manager);
@@ -36,17 +36,24 @@ class SyncPromoHandler : public SyncSetupHandler {
   virtual void ShowSetupUI() OVERRIDE;
 
  private:
-  // Javascript callback handler to close the sync promo.
+  // JavaScript callback handler to close the sync promo.
   void HandleCloseSyncPromo(const base::ListValue* args);
 
-  // Javascript callback handler to initialize the sync promo.
+  // JavaScript callback handler to initialize the sync promo.
   void HandleInitializeSyncPromo(const base::ListValue* args);
 
-  // Javascript callback handler to switch the advanced sync settings. |args| is
+  // JavaScript handler to record a single amount of time throbbers were shown.

[Evan Stade, 2011/11/15 17:45:19]

comment no makey sense

[Dan Beam, 2011/11/15 18:37:13]

JavaScript handler to record the amount of time throbbers were shown.?

[Evan Stade, 2011/11/15 22:46:41]

to record the duration for which the throbber was visible during a (successful?
unsuccessful?) sign-in flow.

[Dan Beam, 2011/11/16 00:09:53]

Done.

+  void HandleRecordThrobberTime(const base::ListValue* args);
+
+  // JavaScript handler to record the number of times a user attempted to sign
+  // in to chrome while they were on the sync promo page.
+  void HandleRecordSignInAttempts(const base::ListValue* args);
+
+  // JavaScript callback handler to switch the advanced sync settings. |args| is
   // the list of arguments passed from JS and should be an empty list.
   void HandleShowAdvancedSettings(const base::ListValue* args);
 
-  // Javascript callback handler to record user actions on the sync promo.
+  // JavaScript callback handler to record user actions on the sync promo.
   void HandleUserFlowAction(const base::ListValue* args);
 
   // Return the number of times the user with the current profile has seen the