Sync Promo: Add more UMA metrics.

chrome/browser/ui/webui/sync_promo_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_HANDLER_H_
 #pragma once
 
 #include "chrome/browser/ui/webui/sync_setup_handler.h"
 
 class PrefService;
 
-// The handler for Javascript messages related to the "sync promo" page.
+// The handler for JavaScript messages related to the "sync promo" page.
 class SyncPromoHandler : public SyncSetupHandler {
  public:
   explicit SyncPromoHandler(ProfileManager* profile_manager);
   virtual ~SyncPromoHandler();
 
   // Called to register our preferences before we use them (so there will be a
   // default if not present yet).
   static void RegisterUserPrefs(PrefService* prefs);
 
   // WebUIMessageHandler implementation.
   virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
   virtual void RegisterMessages() OVERRIDE;
 
   // SyncSetupFlowHandler implementation.
   virtual void ShowConfigure(const base::DictionaryValue& args) OVERRIDE;
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
  protected:
   virtual void ShowSetupUI() OVERRIDE;
 
  private:
-  // Javascript callback handler to close the sync promo.
+  // JavaScript callback handler to close the sync promo.
   void HandleCloseSyncPromo(const base::ListValue* args);
 
-  // Javascript callback handler to initialize the sync promo.
+  // JavaScript callback handler to initialize the sync promo.
   void HandleInitializeSyncPromo(const base::ListValue* args);
 
-  // Javascript callback handler to switch the advanced sync settings. |args| is
+  // JavaScript handler to record a single amount of time throbbers were shown.

[Evan Stade, 2011/11/15 17:45:19]

comment no makey sense

[Dan Beam, 2011/11/15 18:37:13]

JavaScript handler to record the amount of time throbbers were shown.?

[Evan Stade, 2011/11/15 22:46:41]

to record the duration for which the throbber was visible during a (successful?
unsuccessful?) sign-in flow.

[Dan Beam, 2011/11/16 00:09:53]

Done.

+  void HandleRecordThrobberTime(const base::ListValue* args);
+
+  // JavaScript handler to record the number of times a user attempted to sign
+  // in to chrome while they were on the sync promo page.
+  void HandleRecordSignInAttempts(const base::ListValue* args);
+
+  // JavaScript callback handler to switch the advanced sync settings. |args| is
   // the list of arguments passed from JS and should be an empty list.
   void HandleShowAdvancedSettings(const base::ListValue* args);
 
-  // Javascript callback handler to record user actions on the sync promo.
+  // JavaScript callback handler to record user actions on the sync promo.
   void HandleUserFlowAction(const base::ListValue* args);
 
   // Return the number of times the user with the current profile has seen the
   // sync promo.
   int GetViewCount() const;
 
   // Increment the local view count by the specified non-negative integer
   // amount. Returns the new total view count.
   int IncrementViewCountBy(unsigned int amount);
 
@@ skipping 10 matching lines @@
 
   // If the user closes the whole window we'll get a close notification from the
   // tab as well, so this bool acts as a small mutex to only report the close
   // method once.
   bool window_already_closed_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncPromoHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_HANDLER_H_