Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3050)

Unified Diff: chrome/browser/ui/webui/metrics_handler.h

Issue 8528054: Sync Promo: Add more UMA metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/metrics_handler.h
diff --git a/chrome/browser/ui/webui/metrics_handler.h b/chrome/browser/ui/webui/metrics_handler.h
index b86dbf2392a5261c8ba718d9dbc10053103c66bf..b2f3a690b2676fa5ee0cae2953d2cfea522b1dbb 100644
--- a/chrome/browser/ui/webui/metrics_handler.h
+++ b/chrome/browser/ui/webui/metrics_handler.h
@@ -33,6 +33,12 @@ class MetricsHandler : public WebUIMessageHandler {
// user action.
void HandleRecordAction(const base::ListValue* args);
+ // TODO(dbeam): Rename recordInHistgram to something less broad and more
Evan Stade 2011/11/15 17:45:19 move this comment into a bug report and just link
Dan Beam 2011/11/15 18:37:13 Done. http://crbug.com/104338
+ // toward what it's actually doing (UMA_HISTOGRAM_ENUMERATIONs). Also, add a
+ // generic equivalent of UMA_HISTOGRAM_TIMES()/UMA_HISTOGRAM_COUNT() macros to
+ // de-couple from NTP and be able to do UMA easily with one chrome.send() from
+ // WebUI/JavaScript. After this is done, possibly move this a shared location.
+
// Callback for the "metricsHandler:recordInHistogram" message. This records
// into a histogram. |args| contains the histogram name, the value to record,
// and the maximum allowed value, which can be at most 4000. The histogram

Powered by Google App Engine
This is Rietveld 408576698