Chromium Code Reviews| Index: chrome/browser/ui/webui/metrics_handler.h |
| diff --git a/chrome/browser/ui/webui/metrics_handler.h b/chrome/browser/ui/webui/metrics_handler.h |
| index b86dbf2392a5261c8ba718d9dbc10053103c66bf..b2f3a690b2676fa5ee0cae2953d2cfea522b1dbb 100644 |
| --- a/chrome/browser/ui/webui/metrics_handler.h |
| +++ b/chrome/browser/ui/webui/metrics_handler.h |
| @@ -33,6 +33,12 @@ class MetricsHandler : public WebUIMessageHandler { |
| // user action. |
| void HandleRecordAction(const base::ListValue* args); |
| + // TODO(dbeam): Rename recordInHistgram to something less broad and more |
|
Evan Stade
2011/11/15 17:45:19
move this comment into a bug report and just link
Dan Beam
2011/11/15 18:37:13
Done. http://crbug.com/104338
|
| + // toward what it's actually doing (UMA_HISTOGRAM_ENUMERATIONs). Also, add a |
| + // generic equivalent of UMA_HISTOGRAM_TIMES()/UMA_HISTOGRAM_COUNT() macros to |
| + // de-couple from NTP and be able to do UMA easily with one chrome.send() from |
| + // WebUI/JavaScript. After this is done, possibly move this a shared location. |
| + |
| // Callback for the "metricsHandler:recordInHistogram" message. This records |
| // into a histogram. |args| contains the histogram name, the value to record, |
| // and the maximum allowed value, which can be at most 4000. The histogram |