Sync Promo: Add more UMA metrics.

chrome/browser/ui/webui/metrics_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_METRICS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_METRICS_HANDLER_H_
 
 #include "content/browser/webui/web_ui.h"
 
 ///////////////////////////////////////////////////////////////////////////////
@@ skipping 15 matching lines @@
   MetricsHandler();
   virtual ~MetricsHandler();
 
   // WebUIMessageHandler implementation.
   virtual void RegisterMessages() OVERRIDE;
 
   // Callback for the "metricsHandler:recordAction" message. This records a
   // user action.
   void HandleRecordAction(const base::ListValue* args);
 
+  // TODO(dbeam): Rename recordInHistgram to something less broad and more

[Evan Stade, 2011/11/15 17:45:19]

move this comment into a bug report and just link to it here.

[Dan Beam, 2011/11/15 18:37:13]

Done. http://crbug.com/104338

+  // toward what it's actually doing (UMA_HISTOGRAM_ENUMERATIONs). Also, add a
+  // generic equivalent of UMA_HISTOGRAM_TIMES()/UMA_HISTOGRAM_COUNT() macros to
+  // de-couple from NTP and be able to do UMA easily with one chrome.send() from
+  // WebUI/JavaScript. After this is done, possibly move this a shared location.
+
   // Callback for the "metricsHandler:recordInHistogram" message. This records
   // into a histogram. |args| contains the histogram name, the value to record,
   // and the maximum allowed value, which can be at most 4000. The histogram
   // will use at most 100 buckets, one for each 1, 10, or 100 different values,
   // depending on the maximum value.
   void HandleRecordInHistogram(const base::ListValue* args);
 
   // Callback for the "metricsHandler:logEventTime" message.
   void HandleLogEventTime(const base::ListValue* args);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MetricsHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_METRICS_HANDLER_H_