Fix components build on Linux when toolkit_views=1.

Fix components build on Linux when toolkit_views=1.

BUG=90442
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109914

[Dirk Pranke, 2011-11-11 01:52:23]

lgtm

http://codereview.chromium.org/8528019/diff/1/content/browser/renderer_host/g...
File content/browser/renderer_host/gtk_window_utils.h (right):

http://codereview.chromium.org/8528019/diff/1/content/browser/renderer_host/g...
content/browser/renderer_host/gtk_window_utils.h:19: void CONTENT_EXPORT
GetScreenInfoFromNativeWindow(
Nit: the export comes before the return type.

http://codereview.chromium.org/8528019/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view.h (right):

http://codereview.chromium.org/8528019/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view.h:280:
WebKit::WebScreenInfo* results);
Nit: same.

[tony, 2011-11-11 18:02:28]

Thanks, I fixed a few other cases where the return type came first.

[commit-bot: I haz the power, 2011-11-11 18:03:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8528019/5001

[commit-bot: I haz the power, 2011-11-11 18:03:28]

Presubmit check for 8528019-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    content/gpu/gpu_info_collector.h:39

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/geolocation/device_data_provider.h,content/browser/renderer_host/render_widget_host_view.h,content/browser/debugger/worker_devtools_manager.h,content/public/common/url_constants.h,content/gpu/gpu_info_collector.h,content/browser/renderer_host/gtk_window_utils.h

Presubmit checks took 1.2s to calculate.

[tony, 2011-11-11 18:25:08]

+jam for owners

[jam, 2011-11-11 20:29:22]

lgtm

[commit-bot: I haz the power, 2011-11-11 20:32:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8528019/5001

[commit-bot: I haz the power, 2011-11-11 20:32:17]

Presubmit check for 8528019-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    content/gpu/gpu_info_collector.h:39

** Presubmit ERRORS **
Missing LGTM from an OWNER for: content/gpu/gpu_info_collector.h

Presubmit checks took 1.5s to calculate.

[tony, 2011-11-11 21:04:31]

+apatrick +kbr for content/gpu owners

[Ken Russell (switch to Gerrit), 2011-11-11 21:11:21]

lgtm

[commit-bot: I haz the power, 2011-11-11 21:12:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8528019/5001

[commit-bot: I haz the power, 2011-11-11 21:12:13]

Presubmit check for 8528019-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    content/gpu/gpu_info_collector.h:39

Presubmit checks took 1.4s to calculate.