Issue 8526017: Append parameters to webstore URL to indicate launch source.

Issue 8526017: Append parameters to webstore URL to indicate launch source. (Closed)

Created:
9 years, 1 month ago by Evan Stade

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, Erik does not do reviews, kkania, mihaip+watch_chromium.org, Aaron Boodman, arv (Not doing code reviews), robertshield, Paweł Hajdan Jr., estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Append parameters to webstore URL to indicate launch source. BUG=82857 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110050

Patch Set 3 : compile fixes #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -120 lines)			Patch
M	chrome/browser/automation/testing_automation_provider.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background/background_mode_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_management_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_omnibox_api.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	chrome/browser/resources/ntp4/apps_page.js	View	1 2	3 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/shared/js/util.js	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1	8 chunks	+41 lines, -27 lines	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_app_browsertest.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.h	View	1	3 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View		9 chunks	+16 lines, -70 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/8526017/diff/1/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): http://codereview.chromium.org/8526017/diff/1/chrome/browser/ui/browser.h#newcode271 chrome/browser/ui/browser.h:271: const GURL& override_url, Add a description of override_url ...

9 years, 1 month ago (2011-11-11 00:12:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8526017/4001

9 years, 1 month ago (2011-11-15 05:28:37 UTC) #3

commit-bot: I haz the power

9 years, 1 month ago (2011-11-15 05:28:39 UTC) #4

Can't process patch for file chrome/browser/resources/ntp4/apps_page.js.
File's status is None, patchset upload is incomplete.

Expand Messages | Collapse Messages