Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Side by Side Diff: chrome/browser/ui/panels/panel_app_browsertest.cc

Issue 8526017: Append parameters to webstore URL to indicate launch source. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile fixes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser_init.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 5
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "chrome/browser/extensions/extension_browsertest.h" 8 #include "chrome/browser/extensions/extension_browsertest.h"
9 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 last_loaded_extension_id_, false); 46 last_loaded_extension_id_, false);
47 EXPECT_TRUE(extension); 47 EXPECT_TRUE(extension);
48 48
49 size_t browser_count = BrowserList::size(); 49 size_t browser_count = BrowserList::size();
50 50
51 Browser::OpenApplication( 51 Browser::OpenApplication(
52 browser()->profile(), 52 browser()->profile(),
53 extension, 53 extension,
54 // Overriding manifest to open in a panel. 54 // Overriding manifest to open in a panel.
55 extension_misc::LAUNCH_PANEL, 55 extension_misc::LAUNCH_PANEL,
56 GURL(),
56 NEW_WINDOW); 57 NEW_WINDOW);
57 58
58 // Now we have a new browser instance. 59 // Now we have a new browser instance.
59 EXPECT_EQ(browser_count + 1, BrowserList::size()); 60 EXPECT_EQ(browser_count + 1, BrowserList::size());
60 } 61 }
61 62
62 void CloseWindowAndWait(Browser* browser) { 63 void CloseWindowAndWait(Browser* browser) {
63 // Closing a browser window may involve several async tasks. Need to use 64 // Closing a browser window may involve several async tasks. Need to use
64 // message pump and wait for the notification. 65 // message pump and wait for the notification.
65 size_t browser_count = BrowserList::size(); 66 size_t browser_count = BrowserList::size();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 EXPECT_TRUE(new_browser->is_type_panel()); 99 EXPECT_TRUE(new_browser->is_type_panel());
99 100
100 // Now also check that PanelManager has one new Panel under management. 101 // Now also check that PanelManager has one new Panel under management.
101 EXPECT_EQ(1, panel_manager->num_panels()); 102 EXPECT_EQ(1, panel_manager->num_panels());
102 103
103 CloseWindowAndWait(new_browser); 104 CloseWindowAndWait(new_browser);
104 105
105 EXPECT_EQ(0, panel_manager->num_panels()); 106 EXPECT_EQ(0, panel_manager->num_panels());
106 EXPECT_EQ(1u, BrowserList::size()); 107 EXPECT_EQ(1u, BrowserList::size());
107 } 108 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_init.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698