Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1839)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.h

Issue 8526017: Append parameters to webstore URL to indicate launch source. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile fixes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.h
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.h b/chrome/browser/ui/webui/ntp/app_launcher_handler.h
index da8ac0765d91126a514c83f4e22216eb21d3b778..82b55fb1d71fcb3f17de08cfb446e2ac4050acf7 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.h
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.h
@@ -45,9 +45,6 @@ class AppLauncherHandler : public WebUIMessageHandler,
ExtensionService* service,
base::DictionaryValue* value);
- // Callback for pings related to launching apps on the NTP.
- static bool HandlePing(Profile* profile, const std::string& path);
-
// WebUIMessageHandler implementation.
virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
virtual void RegisterMessages() OVERRIDE;
@@ -126,8 +123,7 @@ class AppLauncherHandler : public WebUIMessageHandler,
// Records an app launch in the corresponding |bucket| of the app launch
// histogram. |promo_active| specifies if the web store promotion was active.
- static void RecordAppLaunchByID(bool promo_active,
- extension_misc::AppLaunchBucket bucket);
+ static void RecordAppLaunchByID(extension_misc::AppLaunchBucket bucket);
// Records an app launch in the corresponding |bucket| of the app launch
// histogram if the |escaped_url| corresponds to an installed app.
@@ -184,9 +180,6 @@ class AppLauncherHandler : public WebUIMessageHandler,
// The id of the extension we are prompting the user about.
std::string extension_id_prompting_;
- // Whether the promo is currently being shown.
- bool promo_active_;
-
// When true, we ignore changes to the underlying data rather than immediately
// refreshing. This is useful when making many batch updates to avoid flicker.
bool ignore_changes_;
« no previous file with comments | « chrome/browser/ui/panels/panel_app_browsertest.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698