Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8520036: Revert 110262 - Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. (Closed)

Created:
9 years, 1 month ago by dpolukhin
Modified:
9 years, 1 month ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, yusukes+watch_chromium.org, yoshiki+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, James Su, mihaip+watch_chromium.org
Visibility:
Public.

Description

Revert 110262 - Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. The first landing broke popups on the Mac. Specifically, the auto-resizing of TabContents interfered with how ExtensionViewMac tried to resize itself, causing an infinite feedback loop. Also, we need to defer updating the size of the container until the ExtensionHost is loaded so that we don't display an empty window. BUG=84146 TEST=extensions still work Review URL: http://codereview.chromium.org/8498022 TBR=mpcomplete@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+727 lines, -315 lines) Patch
MM chrome/browser/extensions/browser_action_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/extension_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
MM chrome/browser/extensions/extension_browsertests_misc.cc View 2 chunks +1 line, -4 lines 0 comments Download
MM chrome/browser/extensions/extension_host.h View 7 chunks +112 lines, -33 lines 0 comments Download
MM chrome/browser/extensions/extension_host.cc View 21 chunks +362 lines, -69 lines 0 comments Download
MM chrome/browser/extensions/extension_host_mac.h View 1 chunk +6 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/extension_host_mac.mm View 1 chunk +27 lines, -0 lines 0 comments Download
MM chrome/browser/extensions/extension_process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/extension_webkit_preferences.h View 1 chunk +1 line, -5 lines 0 comments Download
MM chrome/browser/extensions/extension_webkit_preferences.cc View 2 chunks +2 lines, -13 lines 0 comments Download
MM chrome/browser/extensions/extension_webnavigation_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
MM chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
MM chrome/browser/tab_contents/tab_contents_view_mac.h View 1 chunk +0 lines, -5 lines 0 comments Download
MM chrome/browser/tab_contents/tab_contents_view_mac.mm View 3 chunks +1 line, -16 lines 0 comments Download
MM chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/task_manager/task_manager_resource_providers.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/cocoa/extensions/extension_view_mac.h View 3 chunks +5 lines, -11 lines 0 comments Download
MM chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 5 chunks +25 lines, -35 lines 0 comments Download
MM chrome/browser/ui/gtk/extensions/extension_view_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 4 chunks +11 lines, -8 lines 0 comments Download
MM chrome/browser/ui/views/extensions/extension_dialog.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM chrome/browser/ui/views/extensions/extension_popup.h View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/browser/ui/views/extensions/extension_popup.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM chrome/browser/ui/views/extensions/extension_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 3 chunks +47 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 2 chunks +87 lines, -88 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dpolukhin
9 years, 1 month ago (2011-11-16 08:08:39 UTC) #1
Lei Zhang
9 years, 1 month ago (2011-11-16 08:19:12 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698