chrome/browser/extensions/browser_action_apitest.cc - Issue 8520036: Revert 110262 - Have ExtensionHost use TabContents instead of RenderViewHost. Try #2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_action_apitest.cc

Issue 8520036: Revert 110262 - Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/browser_action_apitest.cc

===================================================================

--- chrome/browser/extensions/browser_action_apitest.cc (revision 110269)

+++ chrome/browser/extensions/browser_action_apitest.cc (working copy)

@@ -38,7 +38,7 @@

bool OpenPopup(int index) {

ResultCatcher catcher;

ui_test_utils::WindowedNotificationObserver popup_observer(

- content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,

+ chrome::NOTIFICATION_EXTENSION_POPUP_VIEW_READY,

content::NotificationService::AllSources());

GetBrowserActionsBar().Press(index);

popup_observer.Wait();

Property changes on: chrome/browser/extensions/browser_action_apitest.cc

___________________________________________________________________

Added: svn:mergeinfo

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browsertest.cc » ('j') | no next file with comments »