Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. The first

Have ExtensionHost use TabContents instead of RenderViewHost. Try #2.

The first landing broke popups on the Mac. Specifically, the auto-resizing of TabContents interfered with how ExtensionViewMac tried to resize itself, causing an infinite feedback loop. Also, we need to defer updating the size of the container until the ExtensionHost is loaded so that we don't display an empty window.

BUG=84146
TEST=extensions still work


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110262

[Matt Perry, 2011-11-08 20:21:30]

http://codereview.chromium.org/8498022/diff/1/chrome/browser/ui/cocoa/extensi...
File chrome/browser/ui/cocoa/extensions/extension_view_mac.mm (right):

http://codereview.chromium.org/8498022/diff/1/chrome/browser/ui/cocoa/extensi...
chrome/browser/ui/cocoa/extensions/extension_view_mac.mm:56: NSView* view =
extension_host_->render_view_host()->view()->GetNativeView();
TabContentsViewCocoa doesn't implement setFrameWithDeferredUpdate, so I'm trying
to access the RenderWidgetHostViewCocoa directly. But this doesn't seem to work
either (BrowserActionApiTest.BrowserActionPopup fails because the extension
popup size is always 0).

[Matt Perry, 2011-11-11 21:45:38]

avi: please review the changes to the mac files.

jam: for content approval.

aa: FYI. I didn't change anything since you last reviewed.

[jam, 2011-11-11 21:51:31]

avi is owner in content/browser so I defer to him.

http://codereview.chromium.org/8498022/diff/14007/content/browser/tab_content...
File content/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/8498022/diff/14007/content/browser/tab_content...
content/browser/tab_contents/tab_contents.h:701: virtual void HandleMouseDown()
OVERRIDE;
why not move this?

http://codereview.chromium.org/8498022/diff/14007/content/browser/tab_content...
content/browser/tab_contents/tab_contents.h:702: virtual void
WebUISend(RenderViewHost* render_view_host,
ditto

[Matt Perry, 2011-11-11 21:54:57]

http://codereview.chromium.org/8498022/diff/14007/content/browser/tab_content...
File content/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/8498022/diff/14007/content/browser/tab_content...
content/browser/tab_contents/tab_contents.h:701: virtual void HandleMouseDown()
OVERRIDE;
On 2011/11/11 21:51:31, John Abd-El-Malek wrote:
> why not move this?

oops... merge fail. thanks

[Matt Perry, 2011-11-15 01:51:54]

avi: ping

[Avi (use Gerrit), 2011-11-15 02:45:40]

Mac code LGTM.

[commit-bot: I haz the power, 2011-11-16 00:58:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/8498022/24001

[commit-bot: I haz the power, 2011-11-16 04:30:33]

Commit queue failed due to new patchset.

[commit-bot: I haz the power, 2011-11-16 04:31:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/8498022/26001

[commit-bot: I haz the power, 2011-11-16 05:52:26]

Change committed as 110262

[Dmitry Polukhin, 2011-11-16 08:16:12]

Reverted due to multiple red bots after this commit.