Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8511048: Addressed or cleaned-up a number of TODOs. (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 1 month ago
Reviewers:
jam, sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Addressed or cleaned-up a number of TODOs (some obsolete ones were removed too). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109707

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -29 lines) Patch
M chrome/browser/chromeos/frame/panel_browser_view.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/stubs_aura.cc View 3 chunks +2 lines, -14 lines 2 comments Download
M chrome/browser/ui/webui/ssl_client_certificate_selector_webui.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Emmanuel Saint-loubert-Bié
Cleaned up some Todo and replaced some stubs by actual webui implementations.
9 years, 1 month ago (2011-11-11 03:13:56 UTC) #1
sky
http://codereview.chromium.org/8511048/diff/1/chrome/browser/ui/views/stubs_aura.cc File chrome/browser/ui/views/stubs_aura.cc (right): http://codereview.chromium.org/8511048/diff/1/chrome/browser/ui/views/stubs_aura.cc#newcode40 chrome/browser/ui/views/stubs_aura.cc:40: void ShowSSLClientCertificateSelector( Can we use the one in chrome/browser/ui/webui/ssl_client_certificate_selector_webui.cc ...
9 years, 1 month ago (2011-11-11 16:50:06 UTC) #2
Emmanuel Saint-loubert-Bié
Please see my comment. http://codereview.chromium.org/8511048/diff/1/chrome/browser/ui/views/stubs_aura.cc File chrome/browser/ui/views/stubs_aura.cc (right): http://codereview.chromium.org/8511048/diff/1/chrome/browser/ui/views/stubs_aura.cc#newcode40 chrome/browser/ui/views/stubs_aura.cc:40: void ShowSSLClientCertificateSelector( Actually this is ...
9 years, 1 month ago (2011-11-11 17:35:42 UTC) #3
sky
LGTM
9 years, 1 month ago (2011-11-11 17:46:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8511048/1
9 years, 1 month ago (2011-11-11 20:17:23 UTC) #5
commit-bot: I haz the power
Presubmit check for 8511048-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-11 20:17:28 UTC) #6
Emmanuel Saint-loubert-Bié
Hi John, It seems that I forgot to have you review the change to content/renderer/render_thread_impl.cc. ...
9 years, 1 month ago (2011-11-11 20:21:06 UTC) #7
jam
lgtm
9 years, 1 month ago (2011-11-11 20:29:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8511048/1
9 years, 1 month ago (2011-11-11 20:30:09 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 21:40:23 UTC) #10 
Change committed as 109707

Powered by Google App Engine
This is Rietveld 408576698