Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 8511048: Addressed or cleaned-up a number of TODOs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view.h" 5 #include "chrome/browser/ui/views/frame/browser_view.h"
6 6
7 #if defined(TOOLKIT_USES_GTK) 7 #if defined(TOOLKIT_USES_GTK)
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #endif 9 #endif
10 10
(...skipping 985 matching lines...) Expand 10 before | Expand all | Expand 10 after
996 #if defined(OS_WIN) && !defined(USE_AURA) 996 #if defined(OS_WIN) && !defined(USE_AURA)
997 DefaultSearchView::Show(tab_contents, template_url, profile); 997 DefaultSearchView::Show(tab_contents, template_url, profile);
998 #else 998 #else
999 // TODO(levin): Implement for other platforms. Right now this is behind 999 // TODO(levin): Implement for other platforms. Right now this is behind
1000 // a command line flag which is off. http://crbug.com/38475 1000 // a command line flag which is off. http://crbug.com/38475
1001 #endif 1001 #endif
1002 } 1002 }
1003 1003
1004 void BrowserView::ConfirmAddSearchProvider(const TemplateURL* template_url, 1004 void BrowserView::ConfirmAddSearchProvider(const TemplateURL* template_url,
1005 Profile* profile) { 1005 Profile* profile) {
1006 #if defined(USE_AURA)
1007 browser::ConfirmAddSearchProvider(template_url, profile);
1008 #else
1006 browser::EditSearchEngine(GetWidget()->GetNativeWindow(), template_url, NULL, 1009 browser::EditSearchEngine(GetWidget()->GetNativeWindow(), template_url, NULL,
1007 profile); 1010 profile);
1011 #endif
1008 } 1012 }
1009 1013
1010 void BrowserView::ToggleBookmarkBar() { 1014 void BrowserView::ToggleBookmarkBar() {
1011 bookmark_utils::ToggleWhenVisible(browser_->profile()); 1015 bookmark_utils::ToggleWhenVisible(browser_->profile());
1012 } 1016 }
1013 1017
1014 void BrowserView::ShowAboutChromeDialog() { 1018 void BrowserView::ShowAboutChromeDialog() {
1015 DoShowAboutChromeDialog(); 1019 DoShowAboutChromeDialog();
1016 } 1020 }
1017 1021
(...skipping 1577 matching lines...) Expand 10 before | Expand all | Expand 10 after
2595 Bubble::Show(this->GetWidget(), bounds, views::BubbleBorder::TOP_RIGHT, 2599 Bubble::Show(this->GetWidget(), bounds, views::BubbleBorder::TOP_RIGHT,
2596 views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE, 2600 views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE,
2597 bubble_view, bubble_view); 2601 bubble_view, bubble_view);
2598 } 2602 }
2599 2603
2600 void BrowserView::ShowAvatarBubbleFromAvatarButton() { 2604 void BrowserView::ShowAvatarBubbleFromAvatarButton() {
2601 AvatarMenuButton* button = frame_->GetAvatarMenuButton(); 2605 AvatarMenuButton* button = frame_->GetAvatarMenuButton();
2602 if (button) 2606 if (button)
2603 button->ShowAvatarBubble(); 2607 button->ShowAvatarBubble();
2604 } 2608 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698