Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/ui/views/stubs_aura.cc

Issue 8511048: Addressed or cleaned-up a number of TODOs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 6
7 #include "chrome/browser/bookmarks/bookmark_editor.h" 7 #include "chrome/browser/bookmarks/bookmark_editor.h"
8 #include "chrome/browser/external_protocol/external_protocol_handler.h" 8 #include "chrome/browser/external_protocol/external_protocol_handler.h"
9 #include "chrome/browser/first_run/first_run.h" 9 #include "chrome/browser/first_run/first_run.h"
10 #include "chrome/browser/first_run/first_run_import_observer.h" 10 #include "chrome/browser/first_run/first_run_import_observer.h"
(...skipping 16 matching lines...) Expand all
27 class CryptoModuleBlockingPasswordDelegate; 27 class CryptoModuleBlockingPasswordDelegate;
28 } 28 }
29 namespace net { 29 namespace net {
30 class SSLCertRequestInfo; 30 class SSLCertRequestInfo;
31 class X509Certificate; 31 class X509Certificate;
32 } 32 }
33 namespace views { 33 namespace views {
34 class Widget; 34 class Widget;
35 } 35 }
36 36
37 #if !defined(OS_WIN)
38 class EditSearchEngineControllerDelegate;
39 class TemplateURL;
40 #endif
41
42 namespace browser { 37 namespace browser {
43 38
39 #if defined(OS_WIN)
44 void ShowSSLClientCertificateSelector( 40 void ShowSSLClientCertificateSelector(
sky 2011/11/11 16:50:07 Can we use the one in chrome/browser/ui/webui/ssl_
Emmanuel Saint-loubert-Bié 2011/11/11 17:35:42 Actually this is what we are doing now with this C
45 TabContentsWrapper* parent, 41 TabContentsWrapper* parent,
46 net::SSLCertRequestInfo* cert_request_info, 42 net::SSLCertRequestInfo* cert_request_info,
47 SSLClientAuthHandler* delegate) { 43 SSLClientAuthHandler* delegate) {
48 // TODO(beng): 44 // TODO(beng):
49 NOTIMPLEMENTED(); 45 NOTIMPLEMENTED();
50 } 46 }
47 #endif
51 48
52 void ShowAboutIPCDialog() { 49 void ShowAboutIPCDialog() {
53 // TODO(beng): 50 // TODO(beng):
54 NOTIMPLEMENTED(); 51 NOTIMPLEMENTED();
55 } 52 }
56 53
57 #if defined(USE_NSS) 54 #if defined(USE_NSS)
58 crypto::CryptoModuleBlockingPasswordDelegate* 55 crypto::CryptoModuleBlockingPasswordDelegate*
59 NewCryptoModuleBlockingDialogDelegate( 56 NewCryptoModuleBlockingDialogDelegate(
60 CryptoModulePasswordReason reason, 57 CryptoModulePasswordReason reason,
61 const std::string& server) { 58 const std::string& server) {
62 // TODO(saintlou): 59 // TODO(saintlou):
63 NOTIMPLEMENTED(); 60 NOTIMPLEMENTED();
64 return NULL; 61 return NULL;
65 } 62 }
66 #endif 63 #endif
67 64
68 #if !defined(OS_WIN) 65 #if !defined(OS_WIN)
69 void EditSearchEngine(
70 gfx::NativeWindow,
71 const TemplateURL*,
72 EditSearchEngineControllerDelegate*,
73 Profile*) {
74 // TODO(saintlou):
75 NOTIMPLEMENTED();
76 }
77
78 void ShowCryptoModulePasswordDialog( 66 void ShowCryptoModulePasswordDialog(
79 const std::string& module_name, 67 const std::string& module_name,
80 bool retry, 68 bool retry,
81 CryptoModulePasswordReason reason, 69 CryptoModulePasswordReason reason,
82 const std::string& server, 70 const std::string& server,
83 const CryptoModulePasswordCallback& callback) { 71 const CryptoModulePasswordCallback& callback) {
84 // TODO(saintlou): 72 // TODO(saintlou):
85 NOTIMPLEMENTED(); 73 NOTIMPLEMENTED();
86 } 74 }
87 #endif 75 #endif
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 // TODO(beng); 126 // TODO(beng);
139 NOTIMPLEMENTED(); 127 NOTIMPLEMENTED();
140 } 128 }
141 129
142 } // namespace importer 130 } // namespace importer
143 131
144 // static 132 // static
145 void ExternalProtocolHandler::RunExternalProtocolDialog( 133 void ExternalProtocolHandler::RunExternalProtocolDialog(
146 const GURL& url, int render_process_host_id, int routing_id) { 134 const GURL& url, int render_process_host_id, int routing_id) {
147 } 135 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/webui/ssl_client_certificate_selector_webui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698