Add a method to the controller to close the picker/service tab when a return value is passed.

Add a method to the controller to close the picker/service tab when a return value is passed.

R=jhawkins@chromium.org
BUG=103294, 104140
TEST=WebIntentPickerControllerBrowserTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110547

[James Hawkins, 2011-11-10 00:57:27]

This could use some tests.

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/gtk/web_inten...
File chrome/browser/ui/gtk/web_intent_picker_gtk.cc (right):

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/gtk/web_inten...
chrome/browser/ui/gtk/web_intent_picker_gtk.cc:168: if
(inline_disposition_tab_contents_.get() != NULL)
if (inline_...contents_.get()) suffices.

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/intents/web_i...
File chrome/browser/ui/intents/web_intent_picker_controller.cc (right):

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/intents/web_i...
chrome/browser/ui/intents/web_intent_picker_controller.cc:253: 0,
webkit_glue::WEB_INTENT_PICKER_CANCELLED, string16(), intent_id_));
Does this case mean the client tab was closed?

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/intents/web_i...
chrome/browser/ui/intents/web_intent_picker_controller.cc:259: void
WebIntentPickerController::OnClosing() {
Do we still need this method?

[Greg Billock, 2011-11-10 20:00:42]

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/gtk/web_inten...
File chrome/browser/ui/gtk/web_intent_picker_gtk.cc (right):

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/gtk/web_inten...
chrome/browser/ui/gtk/web_intent_picker_gtk.cc:168: if
(inline_disposition_tab_contents_.get() != NULL)
On 2011/11/10 00:57:28, James Hawkins wrote:
> if (inline_...contents_.get()) suffices.

Done.

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/intents/web_i...
File chrome/browser/ui/intents/web_intent_picker_controller.cc (right):

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/intents/web_i...
chrome/browser/ui/intents/web_intent_picker_controller.cc:253: 0,
webkit_glue::WEB_INTENT_PICKER_CANCELLED, string16(), intent_id_));
On 2011/11/10 00:57:28, James Hawkins wrote:
> Does this case mean the client tab was closed?

If we get a PICKER_CANCELLED, it means the picker was closed without selecting a
service. If an inline service was selected, there's still a cancel operation on
that dialog, but now it really means SERVICE_TAB_CLOSED.

http://codereview.chromium.org/8508019/diff/1/chrome/browser/ui/intents/web_i...
chrome/browser/ui/intents/web_intent_picker_controller.cc:259: void
WebIntentPickerController::OnClosing() {
On 2011/11/10 00:57:28, James Hawkins wrote:
> Do we still need this method?

I think we technically don't need it or the calls to ClosePicker(). I'm a bit
unsure as to how we're going to make the tab modal dialog, though, so I left
them in place pretty much against that process. We can always add them back,
though. Shall I get rid of this?

[James Hawkins, 2011-11-11 22:23:56]

lgtm

[commit-bot: I haz the power, 2011-11-17 18:52:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/8508019/19001

[commit-bot: I haz the power, 2011-11-17 20:09:53]

Change committed as 110547