chrome/browser/ui/intents/web_intent_picker_delegate.h - Issue 8508019: Add a method to the controller to close the picker/service tab when a return value is passed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_delegate.h

Issue 8508019: Add a method to the controller to close the picker/service tab when a return value is passed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change delegate comment to notification sense of OnClosing. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc ('k') | content/browser/intents/intent_injector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/intents/web_intent_picker_delegate.h

diff --git a/chrome/browser/ui/intents/web_intent_picker_delegate.h b/chrome/browser/ui/intents/web_intent_picker_delegate.h

index 898a3440dc61fff4691af19274311834656209c1..9f2c876db37bdfa4de18cb4d81a295cea2704e08 100644

--- a/chrome/browser/ui/intents/web_intent_picker_delegate.h

+++ b/chrome/browser/ui/intents/web_intent_picker_delegate.h

@@ -20,8 +20,7 @@ class WebIntentPickerDelegate {

// it manually or otherwise purposefully.

virtual void OnCancelled() = 0;

- // Callback called when the dialog wants to stop showing (can happen by

- // cancellation or by the user choosing a service).

+ // Callback called when the dialog stops showing.

virtual void OnClosing() = 0;

};

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc ('k') | content/browser/intents/intent_injector.h » ('j') | no next file with comments »