chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc - Issue 8508019: Add a method to the controller to close the picker/service tab when a return value is passed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc

Issue 8508019: Add a method to the controller to close the picker/service tab when a return value is passed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change delegate comment to notification sense of OnClosing. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc ('k') | chrome/browser/ui/intents/web_intent_picker_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc

diff --git a/chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc b/chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc

index 3ea521587269570f04617f198b3100c74339bc8d..bfa7727c4d17c82fba065fa3efe80fbda9c73587 100644

--- a/chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc

+++ b/chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc

@@ -262,7 +262,6 @@ TEST_F(WebIntentPickerControllerTest, Cancel) {

EXPECT_CALL(*controller_, OnClosing())

.WillOnce(Invoke(controller_.get(),

&TestWebIntentPickerController::BaseOnClosing));

- EXPECT_CALL(*picker_factory_, ClosePicker(_));

controller_->ShowDialog(NULL, kAction1, kType);

WaitForDialogToShow();