Remove the remaining exit time destructors from base for linux and chromeos.

Remove the remaining exit time destructors from base for linux and chromeos.

BUG=101600
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109309

[Mark Mentovai, 2011-11-09 21:13:45]

http://codereview.chromium.org/8507022/diff/1/base/linux_util.cc
File base/linux_util.cc (right):

http://codereview.chromium.org/8507022/diff/1/base/linux_util.cc#newcode157
base/linux_util.cc:157: static const char field[] = "Description:\t";
This doesn’t even need to be static.

http://codereview.chromium.org/8507022/diff/1/base/process_linux.cc
File base/process_linux.cc (right):

http://codereview.chromium.org/8507022/diff/1/base/process_linux.cc#newcode15
base/process_linux.cc:15: static bool use_cgroups = false;
All of these should just go and live in Process::SetProcessBackgrounded inside
the OS_CHROMEOS ifdef in there.

http://codereview.chromium.org/8507022/diff/1/base/process_linux.cc#newcode17
base/process_linux.cc:17: static const char kForegroundTasks[] =
And these two won’t need to be static. Or you can just write the const char[]
literals in-line in the FilePath initializations.

[Nico, 2011-11-09 21:24:07]

All done, thanks!

http://codereview.chromium.org/8507022/diff/1/base/linux_util.cc
File base/linux_util.cc (right):

http://codereview.chromium.org/8507022/diff/1/base/linux_util.cc#newcode157
base/linux_util.cc:157: static const char field[] = "Description:\t";
On 2011/11/09 21:13:45, Mark Mentovai wrote:
> This doesn’t even need to be static.

Done. Does it make any difference though? String literals are always static some
way or another. (I assume the compiler knows not to do a "did I set this
already" check for const char[]s)

[Mark Mentovai, 2011-11-09 21:29:09]

http://codereview.chromium.org/8507022/diff/1/base/linux_util.cc
File base/linux_util.cc (right):

http://codereview.chromium.org/8507022/diff/1/base/linux_util.cc#newcode157
base/linux_util.cc:157: static const char field[] = "Description:\t";
Nico wrote:
> Done. Does it make any difference though? String literals are always static
some
> way or another. (I assume the compiler knows not to do a "did I set this
> already" check for const char[]s)

It makes between zero and trivial difference. At low optimization settings, this
still might wind up in the data/rodata (or equivalent) section, which is totally
unnecessary. At high optimization settings, there’s usually no difference.

[Mark Mentovai, 2011-11-09 21:33:17]

LGTM

[commit-bot: I haz the power, 2011-11-09 21:35:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8507022/6