Remove the remaining exit time destructors from base for linux and chromeos.

base/process_linux.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process.h"
 
 #include <errno.h>
 #include <sys/resource.h>
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/stringprintf.h"
 
 #if defined(OS_CHROMEOS)
 static bool use_cgroups = false;

[Mark Mentovai, 2011/11/09 21:13:45]

All of these should just go and live in Process::SetProcessBackgrounded inside
the OS_CHROMEOS ifdef in there.

 static bool cgroups_inited = false;
 static const char kForegroundTasks[] =

[Mark Mentovai, 2011/11/09 21:13:45]

And these two won’t need to be static. Or you can just write the const char[]
literals in-line in the FilePath initializations.

     "/tmp/cgroup/cpu/chrome_renderers/foreground/tasks";
 static const char kBackgroundTasks[] =
     "/tmp/cgroup/cpu/chrome_renderers/background/tasks";
-static FilePath foreground_tasks;
-static FilePath background_tasks;
 #endif
 
 namespace base {
 
 #if defined(OS_CHROMEOS)
 // We are more aggressive in our lowering of background process priority
 // for chromeos as we have much more control over other processes running
 // on the machine.
 const int kPriorityAdjustment = 19;
 #else
 const int kPriorityAdjustment = 5;
 #endif
 
 bool Process::IsProcessBackgrounded() const {
   DCHECK(process_);
   return saved_priority_ == kUnsetProcessPriority;
 }
 
 bool Process::SetProcessBackgrounded(bool background) {
   DCHECK(process_);
 
 #if defined(OS_CHROMEOS)
   // Check for cgroups files. ChromeOS supports these by default. It creates
   // a cgroup mount in /tmp/cgroup and then configures two cpu task groups,
   // one contains at most a single foreground renderer and the other contains
   // all background renderers. This allows us to limit the impact of background
   // renderers on foreground ones to a greater level than simple renicing.
+  FilePath foreground_tasks(kForegroundTasks);
+  FilePath background_tasks(kBackgroundTasks);
   if (!cgroups_inited) {
     cgroups_inited = true;
-    foreground_tasks = FilePath(kForegroundTasks);
-    background_tasks = FilePath(kBackgroundTasks);
     file_util::FileSystemType foreground_type;
     file_util::FileSystemType background_type;
     use_cgroups =
         file_util::GetFileSystemType(foreground_tasks, &foreground_type) &&
         file_util::GetFileSystemType(background_tasks, &background_type) &&
         foreground_type == file_util::FILE_SYSTEM_CGROUP &&
         background_type == file_util::FILE_SYSTEM_CGROUP;
   }
 
   if (use_cgroups) {
@@ skipping 61 matching lines @@
     }
     int result = setpriority(PRIO_PROCESS, process_, saved_priority_);
     // If we can't restore something has gone terribly wrong.
     DPCHECK(result == 0);
     saved_priority_ = kUnsetProcessPriority;
     return true;
   }
 }
 
 }  // namespace base