Remove the remaining exit time destructors from base for linux and chromeos.

base/linux_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/linux_util.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <glib.h>
@@ skipping 136 matching lines @@
     // We do this check only once per process. If it fails, there's
     // little reason to believe it will work if we attempt to run
     // lsb_release again.
     std::vector<std::string> argv;
     argv.push_back("lsb_release");
     argv.push_back("-d");
     std::string output;
     base::GetAppOutput(CommandLine(argv), &output);
     if (output.length() > 0) {
       // lsb_release -d should return: Description:<tab>Distro Info
-      static const std::string field = "Description:\t";
-      if (output.compare(0, field.length(), field) == 0) {
-        SetLinuxDistro(output.substr(field.length()));
+      static const char field[] = "Description:\t";

[Mark Mentovai, 2011/11/09 21:13:45]

This doesn’t even need to be static.

[Nico, 2011/11/09 21:24:07]

Done. Does it make any difference though? String literals are always static some
way or another. (I assume the compiler knows not to do a "did I set this
already" check for const char[]s)

[Mark Mentovai, 2011/11/09 21:29:10]

Nico wrote:
It makes between zero and trivial difference. At low optimization settings, this
still might wind up in the data/rodata (or equivalent) section, which is totally
unnecessary. At high optimization settings, there’s usually no difference.

+      if (output.compare(0, strlen(field), field) == 0) {
+        SetLinuxDistro(output.substr(strlen(field)));
       }
     }
     distro_state_singleton->CheckFinished();
     return g_linux_distro;
   } else if (STATE_CHECK_STARTED == state) {
     // If the distro check above is in progress in some other thread, we're
     // not going to wait for the results.
     return "Unknown";
   } else {
     // In STATE_CHECK_FINISHED, no more writing to |linux_distro|.
@@ skipping 126 matching lines @@
 
     if (0 == strncmp(expected_data.c_str(), syscall_data.get(),
                      expected_data.length())) {
       return current_tid;
     }
   }
   return -1;
 }
 
 }  // namespace base