Don't close crashed tabs from extensions with background pages.

chrome/browser/renderer_host/chrome_render_view_host_observer.cc

Index: chrome/browser/renderer_host/chrome_render_view_host_observer.cc
diff --git a/chrome/browser/renderer_host/chrome_render_view_host_observer.cc b/chrome/browser/renderer_host/chrome_render_view_host_observer.cc
index 586ecdab8e907750bb0fc7323156cd2355f8b47c..63065e0ad9273942166fecdcf8f8c062368939ce 100644
--- a/chrome/browser/renderer_host/chrome_render_view_host_observer.cc
+++ b/chrome/browser/renderer_host/chrome_render_view_host_observer.cc
@@ -139,7 +139,12 @@ const Extension* ChromeRenderViewHostObserver::GetExtension() {
   if (!service)
     return NULL;
 
-  // May be null if somebody typos a chrome-extension:// URL.
+  // Reload the extension if it extension has crashed.

[Matt Perry, 2011/11/10 22:07:59]

it = the

[Yoyo Zhou, 2011/11/10 23:26:30]

Fixed.

+  if (service->GetTerminatedExtension(site.host()))
+    service->ReloadExtension(site.host());

[Matt Perry, 2011/11/10 22:18:13]

Wait, this won't work for unpacked extensions, right? Since we don't have their
manifests in memory, we have to load them asynchronously.

I guess it's not a big deal, but ideally we would make the reload operation
async, and wait until the extension is loaded. I'm sure that's a lot more work
though.

[Yoyo Zhou, 2011/11/10 23:26:30]

Surprisingly, it does seem to work (although I'm sure there is a race, e.g. if I
set a breakpoint in the debugger at this point, it only works flakily).

We do have a function to load unpacked extensions synchronously
(LoadFromCommandLine), but it would take more to make ReloadExtension use it.

Blocking navigation (the reload) seems harder to accomplish.

I'll add a TODO for this.

[Matt Perry, 2011/11/10 23:28:21]

We shouldn't block the UI thread on reload for this.
SGTM.

+
+  // May be null if the extension doesn't exist, for example if somebody typos
+  // a chrome-extension:// URL.
   return service->GetExtensionByURL(site);
 }