Don't close crashed tabs from extensions with background pages.

chrome/browser/renderer_host/chrome_render_view_host_observer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_render_view_host_observer.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/dom_operation_notification_details.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/net/predictor.h"
@@ skipping 121 matching lines @@
   SiteInstance* site_instance = render_view_host()->site_instance();
   const GURL& site = site_instance->site();
 
   if (!site.SchemeIs(chrome::kExtensionScheme))
     return NULL;
 
   ExtensionService* service = profile_->GetExtensionService();
   if (!service)
     return NULL;
 
-  // May be null if somebody typos a chrome-extension:// URL.
+  // Reload the extension if it extension has crashed.

[Matt Perry, 2011/11/10 22:07:59]

it = the

[Yoyo Zhou, 2011/11/10 23:26:30]

Fixed.

+  if (service->GetTerminatedExtension(site.host()))
+    service->ReloadExtension(site.host());

[Matt Perry, 2011/11/10 22:18:13]

Wait, this won't work for unpacked extensions, right? Since we don't have their
manifests in memory, we have to load them asynchronously.

I guess it's not a big deal, but ideally we would make the reload operation
async, and wait until the extension is loaded. I'm sure that's a lot more work
though.

[Yoyo Zhou, 2011/11/10 23:26:30]

Surprisingly, it does seem to work (although I'm sure there is a race, e.g. if I
set a breakpoint in the debugger at this point, it only works flakily).

We do have a function to load unpacked extensions synchronously
(LoadFromCommandLine), but it would take more to make ReloadExtension use it.

Blocking navigation (the reload) seems harder to accomplish.

I'll add a TODO for this.

[Matt Perry, 2011/11/10 23:28:21]

We shouldn't block the UI thread on reload for this.
SGTM.

+
+  // May be null if the extension doesn't exist, for example if somebody typos
+  // a chrome-extension:// URL.
   return service->GetExtensionByURL(site);
 }
 
 void ChromeRenderViewHostObserver::RemoveRenderViewHostForExtensions(
     RenderViewHost* rvh) {
   ExtensionProcessManager* process_manager =
       profile_->GetExtensionProcessManager();
   if (process_manager)
     process_manager->UnregisterRenderViewHost(rvh);
 }
 
 void ChromeRenderViewHostObserver::OnDomOperationResponse(
     const std::string& json_string, int automation_id) {
   DomOperationNotificationDetails details(json_string, automation_id);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_DOM_OPERATION_RESPONSE,
       content::Source<RenderViewHost>(render_view_host()),
       content::Details<DomOperationNotificationDetails>(&details));
 }
 
 void ChromeRenderViewHostObserver::OnFocusedEditableNodeTouched() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_FOCUSED_EDITABLE_NODE_TOUCHED,
       content::Source<RenderViewHost>(render_view_host()),
       content::NotificationService::NoDetails());
 }