Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: content/browser/tab_contents/render_view_host_manager.cc

Issue 8496024: Don't close crashed tabs from extensions with background pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix info map Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/render_view_host_manager.cc
diff --git a/content/browser/tab_contents/render_view_host_manager.cc b/content/browser/tab_contents/render_view_host_manager.cc
index 61b084b3f1f2e202b565eeb9e652a7dc0a8193a9..5480afc0f41fc6202cf068db592a6c673e77efec 100644
--- a/content/browser/tab_contents/render_view_host_manager.cc
+++ b/content/browser/tab_contents/render_view_host_manager.cc
@@ -96,6 +96,7 @@ RenderViewHost* RenderViewHostManager::Navigate(const NavigationEntry& entry) {
// If the renderer crashed, then try to create a new one to satisfy this
// navigation request.
+ // TODO(yoz): Should we try to reload extensions here instead??
Matt Perry 2011/11/10 22:07:59 content/ shouldn't know about extensions. if we wa
Yoyo Zhou 2011/11/10 23:26:30 Yeah, this was from an earlier approach.
if (!dest_render_view_host->IsRenderViewLive()) {
if (!InitRenderView(dest_render_view_host, entry))
return NULL;

Powered by Google App Engine
This is Rietveld 408576698