Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autofill/autofill_external_delegate.h

Index: chrome/browser/autofill/autofill_external_delegate.h
diff --git a/chrome/browser/autofill/autofill_external_delegate.h b/chrome/browser/autofill/autofill_external_delegate.h
index 7a88c9813fe7b074ce0d182cda22799134111131..6a83ec51b1ffd93c818d5ce73bddc7b267f13586 100644
--- a/chrome/browser/autofill/autofill_external_delegate.h
+++ b/chrome/browser/autofill/autofill_external_delegate.h
@@ -13,6 +13,10 @@
 class AutofillManager;
 class TabContentsWrapper;
 
+namespace gfx {
+class Rect;
+}
+
 namespace webkit_glue {
 struct FormData;
 struct FormField;
@@ -45,6 +49,16 @@ class AutofillExternalDelegate {
       const std::vector<string16>& autofill_icons,
       const std::vector<int>& autofill_unique_ids) = 0;
 
+  // Set the bounds of the element we are providing the Autofill data

[John Grabowski, 2011/11/08 20:46:02]

Be more specific.  E.g. state clearly this is the bounds of the text field to be
autocompleted.  Clearly state if the coordinates are page-relative or
screen-relative.

[csharp, 2011/11/09 16:18:37]

Done.

+  // for.
+  virtual void SetAutofillElementBounds(const gfx::Rect& bounds) = 0;
+
+  // Show the Autofill popup.
+  virtual void ShowAutofillPopup() = 0;

[John Grabowski, 2011/11/08 20:46:02]

HideAutofillPopup() seems fine since it should be safe to call it no matter what

(e.g. when text field loses focus).  But ShowAutofillPopup() might be poorly
named.  If all autofill logic is moved to the browser, webkit wouldn't even know
if the autofill popup is open, or can be opened because we have suggestions.

[csharp, 2011/11/09 16:18:37]

True, I had removed the Webkit call to it already but had forgotten to take it
out to. OnSuggestionReturned should be the only signal we need to know when to
show the popup.
On 2011/11/08 20:46:02, John Grabowski wrote:

+
+  // Hide the Autofill poup.
+  virtual void HideAutofillPopup() = 0;
+
   // Platforms that wish to implement an external Autofill delegate
   // MUST implement this.  The 1st arg is the tab contents that owns
   // this delegate; the second is the Autofill manager owned by the