Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autocomplete_history_manager.cc

Index: chrome/browser/autocomplete_history_manager.cc
diff --git a/chrome/browser/autocomplete_history_manager.cc b/chrome/browser/autocomplete_history_manager.cc
index ea4e3998508430f7b54a7cb95ef8d17d876db979..c5f4cab7eed9a4bb295d1ebded2af2bd18d81eb1 100644
--- a/chrome/browser/autocomplete_history_manager.cc
+++ b/chrome/browser/autocomplete_history_manager.cc
@@ -219,6 +219,11 @@ void AutocompleteHistoryManager::OnWebDataServiceRequestDone(
   SendSuggestions(&suggestions);
 }
 
+void AutocompleteHistoryManager::SetExternalDelegate(
+    AutofillExternalDelegate* delegate) {
+  void SetExternalDelegate(AutofillExternalDelegate* delegate);

[John Grabowski, 2011/11/08 20:46:02]

This doesn't look like valid code.

[Ilya Sherman, 2011/11/08 21:06:16]

I don't think this is quite the change you wanted to make ;)

[csharp, 2011/11/09 16:18:37]

Fixed. Surprisingly this code did compile without trouble. 

On 2011/11/08 21:06:16, Ilya Sherman wrote:

+}
+
 AutocompleteHistoryManager::AutocompleteHistoryManager(
     TabContents* tab_contents,
     Profile* profile,
@@ -265,6 +270,7 @@ void AutocompleteHistoryManager::SendSuggestions(
   }
 
   if (external_delegate_) {
+    Send(new AutofillMsg_SetHasExternalDelegate(routing_id(), true));

[John Grabowski, 2011/11/08 20:46:02]

You probably want to make this call at SetExternalDelegate() time.

[csharp, 2011/11/09 16:18:37]

We no longer make SetExternalDelegate calls, so problem removed.

On 2011/11/08 20:46:02, John Grabowski wrote:

     external_delegate_->OnSuggestionsReturned(
         query_id_,
         autofill_values_,