Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autofill/autofill_external_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #pragma once
 
 #include <vector>
 
 #include "base/string16.h"
 
 class AutofillManager;
 class TabContentsWrapper;
 
+namespace gfx {
+class Rect;
+}
+
 namespace webkit_glue {
 struct FormData;
 struct FormField;
 }  // namespace webkit_glue
 
 // Delegate for external processing of Autocomplete and Autofill
 // display and selection.
 class AutofillExternalDelegate {
  public:
   virtual ~AutofillExternalDelegate();
@@ skipping 12 matching lines @@
   // Records query results.  Displays them to the user with an external
   // Autofill popup that lives completely in the browser.  Called when
   // an Autofill query result is available.
   virtual void OnSuggestionsReturned(
       int query_id,
       const std::vector<string16>& autofill_values,
       const std::vector<string16>& autofill_labels,
       const std::vector<string16>& autofill_icons,
       const std::vector<int>& autofill_unique_ids) = 0;
 
+  // Set the bounds of the element we are providing the Autofill data

[John Grabowski, 2011/11/08 20:46:02]

Be more specific.  E.g. state clearly this is the bounds of the text field to be
autocompleted.  Clearly state if the coordinates are page-relative or
screen-relative.

[csharp, 2011/11/09 16:18:37]

Done.

+  // for.
+  virtual void SetAutofillElementBounds(const gfx::Rect& bounds) = 0;
+
+  // Show the Autofill popup.
+  virtual void ShowAutofillPopup() = 0;

[John Grabowski, 2011/11/08 20:46:02]

HideAutofillPopup() seems fine since it should be safe to call it no matter what

(e.g. when text field loses focus).  But ShowAutofillPopup() might be poorly
named.  If all autofill logic is moved to the browser, webkit wouldn't even know
if the autofill popup is open, or can be opened because we have suggestions.

[csharp, 2011/11/09 16:18:37]

True, I had removed the Webkit call to it already but had forgotten to take it
out to. OnSuggestionReturned should be the only signal we need to know when to
show the popup.
On 2011/11/08 20:46:02, John Grabowski wrote:

+
+  // Hide the Autofill poup.
+  virtual void HideAutofillPopup() = 0;
+
   // Platforms that wish to implement an external Autofill delegate
   // MUST implement this.  The 1st arg is the tab contents that owns
   // this delegate; the second is the Autofill manager owned by the
   // tab contents.
   static AutofillExternalDelegate* Create(TabContentsWrapper*,
                                           AutofillManager*);
 
  protected:
   explicit AutofillExternalDelegate(TabContentsWrapper* tab_contents_wrapper);
 
  private:
   TabContentsWrapper* tab_contents_wrapper_;  // weak; owns me.
 
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_