Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autocomplete_history_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete_history_manager.h"
 
 #include <vector>
 
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
@@ skipping 201 matching lines @@
     return;
   }
 
   DCHECK_EQ(AUTOFILL_VALUE_RESULT, result->GetType());
   const WDResult<std::vector<string16> >* autofill_result =
       static_cast<const WDResult<std::vector<string16> >*>(result);
   std::vector<string16> suggestions = autofill_result->GetValue();
   SendSuggestions(&suggestions);
 }
 
+void AutocompleteHistoryManager::SetExternalDelegate(
+    AutofillExternalDelegate* delegate) {
+  void SetExternalDelegate(AutofillExternalDelegate* delegate);

[John Grabowski, 2011/11/08 20:46:02]

This doesn't look like valid code.

[Ilya Sherman, 2011/11/08 21:06:16]

I don't think this is quite the change you wanted to make ;)

[csharp, 2011/11/09 16:18:37]

Fixed. Surprisingly this code did compile without trouble. 

On 2011/11/08 21:06:16, Ilya Sherman wrote:

+}
+
 AutocompleteHistoryManager::AutocompleteHistoryManager(
     TabContents* tab_contents,
     Profile* profile,
     WebDataService* wds)
     : TabContentsObserver(tab_contents),
       profile_(profile),
       web_data_service_(wds),
       pending_query_handle_(0),
       query_id_(0) {
   autofill_enabled_.Init(
@@ skipping 26 matching lines @@
       if (unique) {
         autofill_values_.push_back((*suggestions)[i]);
         autofill_labels_.push_back(string16());
         autofill_icons_.push_back(string16());
         autofill_unique_ids_.push_back(0);  // 0 means no profile.
       }
     }
   }
 
   if (external_delegate_) {
+    Send(new AutofillMsg_SetHasExternalDelegate(routing_id(), true));

[John Grabowski, 2011/11/08 20:46:02]

You probably want to make this call at SetExternalDelegate() time.

[csharp, 2011/11/09 16:18:37]

We no longer make SetExternalDelegate calls, so problem removed.

On 2011/11/08 20:46:02, John Grabowski wrote:

     external_delegate_->OnSuggestionsReturned(
         query_id_,
         autofill_values_,
         autofill_labels_,
         autofill_icons_,
         autofill_unique_ids_);
   }
 
   Send(new AutofillMsg_SuggestionsReturned(routing_id(),
                                            query_id_,
                                            autofill_values_,
                                            autofill_labels_,
                                            autofill_icons_,
                                            autofill_unique_ids_));
 
   query_id_ = 0;
   autofill_values_.clear();
   autofill_labels_.clear();
   autofill_icons_.clear();
   autofill_unique_ids_.clear();
 }