Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/renderer/autofill/autofill_agent.h

Issue 8490017: Setting up external delegate calls to allow a future delegate to handle autofill (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/autofill_agent.h
diff --git a/chrome/renderer/autofill/autofill_agent.h b/chrome/renderer/autofill/autofill_agent.h
index 61c36e62b6dd394bc39775c431ad5282feb3ca04..55c572bc611a883108ec32c6f348d1cbcd7854f7 100644
--- a/chrome/renderer/autofill/autofill_agent.h
+++ b/chrome/renderer/autofill/autofill_agent.h
@@ -101,9 +101,12 @@ class AutofillAgent : public content::RenderViewObserver,
void OnFieldTypePredictionsAvailable(
const std::vector<webkit_glue::FormDataPredictions>& forms);
- // For external Autofill selection.
+ // For external Autofill selection.
void OnSelectAutofillSuggestionAtIndex(int listIndex);
+ // For setting if an external autofill delegate is in use.
+ void HasExternalDelegate(bool has_external_delegate);
Ilya Sherman 2011/11/07 21:48:49 nit: OnSetHasExternalDelegate
csharp1 2011/11/08 19:59:00 Done.
+
// Called in a posted task by textFieldDidChange() to work-around a WebKit bug
// http://bugs.webkit.org/show_bug.cgi?id=16976
void TextFieldDidChangeImpl(const WebKit::WebInputElement& element);
@@ -174,6 +177,10 @@ class AutofillAgent : public content::RenderViewObserver,
// currently editing? Used to keep track of state for metrics logging.
bool has_shown_autofill_popup_for_current_edit_;
+ // Is an external delegate in the browser handling showing the autofill
+ // popup. This deciedes if we communicate with the delegate or webkit.
Ilya Sherman 2011/11/07 21:48:49 nit: "popup. " -> "popup? " (period becomes quest
csharp1 2011/11/08 19:59:00 Done.
+ bool has_external_delegate_;
+
base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
friend class PasswordAutofillManagerTest;

Powered by Google App Engine
This is Rietveld 408576698