Setting up external delegate calls to allow a future delegate to handle autofill

chrome/common/autofill_messages.h

Index: chrome/common/autofill_messages.h
diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h
index c5a1ddd3e01f4de33d76cba945cbb5c29c57bb95..708e35079e2e063e7e82237648730d9ba430519f 100644
--- a/chrome/common/autofill_messages.h
+++ b/chrome/common/autofill_messages.h
@@ -92,6 +92,11 @@ IPC_MESSAGE_ROUTED1(
 IPC_MESSAGE_ROUTED1(AutofillMsg_SelectAutofillSuggestionAtIndex,
                     int /* listIndex */)
 
+// Inform the renderer that the browser has an external delegate
+// that will display the auotfill popup.

[Ilya Sherman, 2011/11/07 21:48:49]

nit: auotfill -> Autofill

[csharp1, 2011/11/08 19:59:00]

Done.

+IPC_MESSAGE_ROUTED1(AutofillMsg_HasExternalDelegate,
+                    bool /* has_external_delegate */)

[Ilya Sherman, 2011/11/07 21:48:49]

nit: _SetHasExternalDelegate

[csharp1, 2011/11/08 19:59:00]

Done.

+
 // Autofill messages sent from the renderer to the browser.
 
 // Notification that forms have been seen that are candidates for
@@ -155,4 +160,23 @@ IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemoveAutocompleteEntry,
 // Instructs the browser to show the Autofill dialog.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_ShowAutofillDialog)
 
+// Messages to the Autofill delegate (which lives in the browser) from the
+// renderer.
+
+// Tell the external delegate which autofill suggestions to show.
+IPC_MESSAGE_ROUTED5(AutofillDelegateMsg_ShowAutofillSuggestions,
+                    int /* id of the request message */,
+                    std::vector<string16> /* names */,
+                    std::vector<string16> /* labels */,
+                    std::vector<string16> /* icons */,
+                    std::vector<int> /* unique_ids */)

[Ilya Sherman, 2011/11/07 21:48:49]

This should probably be a method call within the browser process, called from
AutofillManager::OnQueryFormFieldAutofill().

[csharp1, 2011/11/08 19:59:00]

Ok, with some of autofill_agents logic repeated in the browser we can even avoid
adding a new call to ShowAutofillSuggestions, the call is already made by
AutocompleteHistoryManager (which is called at the end of
OnQueryFormFieldAutofill())
On 2011/11/07 21:48:49, Ilya Sherman wrote:

+
+// Tells the external delegate where the element it is working on appears.
+IPC_MESSAGE_ROUTED4(AutofillDelegateMsg_AutofillElementBounds,
+                    int /* x */,
+                    int /* y */,
+                    int /* width */,
+                    int /* height */)

[Ilya Sherman, 2011/11/07 21:48:49]

Can these coordinates simply be passed as an additional gfx::Rect parameter to
the QueryFormFieldAutofill message, or do the two messages need to be sent at
distinct times?

[csharp1, 2011/11/08 19:59:00]

QueryFormFieldAutofill looks like it would be a prefect place to pass this
information. However I don't think we can pass a gfx::Rect with the IPC calls
since its data members are private, and as far as I can tell we can only pass
structs/classes that have the members we want to copy as public. WebKit::WebRect
could be used, since it's members are public, but I assume we don't want to be
using WebKit classes too much internally. Should we create a new rect class to
pass or am I overlooking some way of being able to pass gfx::Rect.

On 2011/11/07 21:48:49, Ilya Sherman wrote:

[Ilya Sherman, 2011/11/08 21:06:16]

You can pass a gfx::Rect by adding serialization/deserialization code for the
IPC macros to use.  For some examples, take a look at how
src/chrome/common/automation_messages does this for ContextMenuModel's, and how
src/ipc/ipc_message_utils does this for strings, vectors, etc.

[csharp, 2011/11/09 16:18:37]

As I started looking there I saw a case where gfx::Rect was just used with no
problem, so it turns out it just works :)

On 2011/11/08 21:06:16, Ilya Sherman wrote:

 
+// Instructs the external delegate to hide the Autofill popup.
+IPC_MESSAGE_ROUTED0(AutofillDelegateMsg_HideAutofillPopup)

[Ilya Sherman, 2011/11/07 21:48:49]

nit: This should be named AutofillHostMsg_*. The general pattern we try to
follow in the Chrome code is that there is a Foo object in the renderer and a
FooHost object in the browser that communicate with one another.  To keep things
simple, we generally avoid exposing further implementation details in the
message name's prefix.

[csharp1, 2011/11/08 19:59:00]

Done.