Setting up external delegate calls to allow a future delegate to handle autofill

chrome/renderer/autofill/autofill_agent.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_
 #define CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 83 matching lines @@
 
   void OnSuggestionsReturned(int query_id,
                              const std::vector<string16>& values,
                              const std::vector<string16>& labels,
                              const std::vector<string16>& icons,
                              const std::vector<int>& unique_ids);
   void OnFormDataFilled(int query_id, const webkit_glue::FormData& form);
   void OnFieldTypePredictionsAvailable(
       const std::vector<webkit_glue::FormDataPredictions>& forms);
 
- // For external Autofill selection.
+  // For external Autofill selection.
   void OnSelectAutofillSuggestionAtIndex(int listIndex);
 
+  // For setting if an external autofill delegate is in use.
+  void HasExternalDelegate(bool has_external_delegate);

[Ilya Sherman, 2011/11/07 21:48:49]

nit: OnSetHasExternalDelegate

[csharp1, 2011/11/08 19:59:00]

Done.

+
   // Called in a posted task by textFieldDidChange() to work-around a WebKit bug
   // http://bugs.webkit.org/show_bug.cgi?id=16976
   void TextFieldDidChangeImpl(const WebKit::WebInputElement& element);
 
   // Shows the autofill suggestions for |element|.
   // This call is asynchronous and may or may not lead to the showing of a
   // suggestion popup (no popup is shown if there are no available suggestions).
   // |autofill_on_empty_values| specifies whether suggestions should be shown
   // when |element| contains no text.
   // |requires_caret_at_end| specifies whether suggestions should be shown when
@@ skipping 50 matching lines @@
   // The menu index of the "Clear" menu item.
   int suggestions_clear_index_;
 
   // The menu index of the "Autofill options..." menu item.
   int suggestions_options_index_;
 
   // Have we already shown Autofill suggestions for the field the user is
   // currently editing?  Used to keep track of state for metrics logging.
   bool has_shown_autofill_popup_for_current_edit_;
 
+  // Is an external delegate in the browser handling showing the autofill
+  // popup. This deciedes if we communicate with the delegate or webkit.

[Ilya Sherman, 2011/11/07 21:48:49]

nit: "popup. " -> "popup?  " (period becomes question mark, one space becomes
two spaces); "deciedes if" -> "determines whether"; "webkit" -> "WebKit".

[csharp1, 2011/11/08 19:59:00]

Done.

+  bool has_external_delegate_;
+
   base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
 
   friend class PasswordAutofillManagerTest;
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, SendForms);
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, FillFormElement);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, WaitUsername);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionAccept);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionSelect);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_