Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 8489002: Pepper: Fix nits mentioned in review in audio input code. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jam, yzshen+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Pepper: Fix nits mentioned in review in audio input code. In particular, dmichael's comments in http://codereview.chromium.org/8574029. TBR=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M content/renderer/pepper_plugin_delegate_impl.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M ppapi/api/trusted/ppb_audio_input_trusted_dev.idl View 4 chunks +10 lines, -11 lines 0 comments Download
M ppapi/c/trusted/ppb_audio_input_trusted_dev.h View 2 chunks +11 lines, -12 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_input_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_input_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
9 years, 1 month ago (2011-11-21 20:55:52 UTC) #1
dmichael (off chromium)
lgtm
9 years, 1 month ago (2011-11-21 21:22:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8489002/1
9 years, 1 month ago (2011-11-21 21:25:39 UTC) #3
commit-bot: I haz the power
Presubmit check for 8489002-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-21 21:25:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8489002/1
9 years, 1 month ago (2011-11-21 21:47:25 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 21:47:29 UTC) #6
Presubmit check for 8489002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars

Presubmit checks took 1.3s to calculate.

Powered by Google App Engine
This is Rietveld 408576698