Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: webkit/plugins/ppapi/ppb_audio_impl.h

Issue 8489002: Pepper: Fix nits mentioned in review in audio input code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_ 5 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_
6 #define WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_ 6 #define WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/shared_memory.h" 10 #include "base/shared_memory.h"
(...skipping 27 matching lines...) Expand all
38 38
39 virtual ~PPB_Audio_Impl(); 39 virtual ~PPB_Audio_Impl();
40 40
41 // Creation function for untrusted plugins. This handles all initialization 41 // Creation function for untrusted plugins. This handles all initialization
42 // and will return 0 on failure. 42 // and will return 0 on failure.
43 static PP_Resource Create(PP_Instance instance, 43 static PP_Resource Create(PP_Instance instance,
44 PP_Resource config_id, 44 PP_Resource config_id,
45 PPB_Audio_Callback audio_callback, 45 PPB_Audio_Callback audio_callback,
46 void* user_data); 46 void* user_data);
47 47
48 // Initialization function for non-trusted init. 48 // Initialization function for trusted init.
49 bool Init(PP_Resource config_id, 49 bool Init(PP_Resource config_id,
50 PPB_Audio_Callback user_callback, void* user_data); 50 PPB_Audio_Callback user_callback,
51 void* user_data);
51 52
52 // Resource overrides. 53 // Resource overrides.
53 virtual ::ppapi::thunk::PPB_Audio_API* AsPPB_Audio_API(); 54 virtual ::ppapi::thunk::PPB_Audio_API* AsPPB_Audio_API();
54 55
55 // PPB_Audio_API implementation. 56 // PPB_Audio_API implementation.
56 virtual PP_Resource GetCurrentConfig() OVERRIDE; 57 virtual PP_Resource GetCurrentConfig() OVERRIDE;
57 virtual PP_Bool StartPlayback() OVERRIDE; 58 virtual PP_Bool StartPlayback() OVERRIDE;
58 virtual PP_Bool StopPlayback() OVERRIDE; 59 virtual PP_Bool StopPlayback() OVERRIDE;
59 virtual int32_t OpenTrusted(PP_Resource config_id, 60 virtual int32_t OpenTrusted(PP_Resource config_id,
60 PP_CompletionCallback create_callback) OVERRIDE; 61 PP_CompletionCallback create_callback) OVERRIDE;
(...skipping 13 matching lines...) Expand all
74 // own this pointer but are responsible for calling Shutdown on it. 75 // own this pointer but are responsible for calling Shutdown on it.
75 PluginDelegate::PlatformAudio* audio_; 76 PluginDelegate::PlatformAudio* audio_;
76 77
77 DISALLOW_COPY_AND_ASSIGN(PPB_Audio_Impl); 78 DISALLOW_COPY_AND_ASSIGN(PPB_Audio_Impl);
78 }; 79 };
79 80
80 } // namespace ppapi 81 } // namespace ppapi
81 } // namespace webkit 82 } // namespace webkit
82 83
83 #endif // WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_ 84 #endif // WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_
OLDNEW
« no previous file with comments | « ppapi/c/trusted/ppb_audio_input_trusted_dev.h ('k') | webkit/plugins/ppapi/ppb_audio_input_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698