Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: content/renderer/pepper_plugin_delegate_impl.cc

Issue 8489002: Pepper: Fix nits mentioned in review in audio input code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/api/trusted/ppb_audio_input_trusted_dev.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper_plugin_delegate_impl.cc
diff --git a/content/renderer/pepper_plugin_delegate_impl.cc b/content/renderer/pepper_plugin_delegate_impl.cc
index e1453e593c353d6e29ec0c626c0543b8a464d351..21530563db588a81b6dea5a81c6cb47d88fb0f69 100644
--- a/content/renderer/pepper_plugin_delegate_impl.cc
+++ b/content/renderer/pepper_plugin_delegate_impl.cc
@@ -163,7 +163,6 @@ class PlatformImage2DImpl
DISALLOW_COPY_AND_ASSIGN(PlatformImage2DImpl);
};
-
class PlatformAudioImpl
: public webkit::ppapi::PluginDelegate::PlatformAudio,
public AudioMessageFilter::Delegate,
@@ -188,9 +187,9 @@ class PlatformAudioImpl
webkit::ppapi::PluginDelegate::PlatformAudioCommonClient* client);
// PlatformAudio implementation (called on main thread).
- virtual bool StartPlayback();
- virtual bool StopPlayback();
- virtual void ShutDown();
+ virtual bool StartPlayback() OVERRIDE;
+ virtual bool StopPlayback() OVERRIDE;
+ virtual void ShutDown() OVERRIDE;
private:
// I/O thread backends to above functions.
@@ -199,21 +198,22 @@ class PlatformAudioImpl
void StopPlaybackOnIOThread();
void ShutDownOnIOThread();
- virtual void OnRequestPacket(AudioBuffersState buffers_state) {
+ virtual void OnRequestPacket(AudioBuffersState buffers_state) OVERRIDE {
LOG(FATAL) << "Should never get OnRequestPacket in PlatformAudioImpl";
}
- virtual void OnStateChanged(AudioStreamState state) {}
+ virtual void OnStateChanged(AudioStreamState state) OVERRIDE {}
- virtual void OnCreated(base::SharedMemoryHandle handle, uint32 length) {
+ virtual void OnCreated(base::SharedMemoryHandle handle,
+ uint32 length) OVERRIDE {
LOG(FATAL) << "Should never get OnCreated in PlatformAudioImpl";
}
virtual void OnLowLatencyCreated(base::SharedMemoryHandle handle,
base::SyncSocket::Handle socket_handle,
- uint32 length);
+ uint32 length) OVERRIDE;
- virtual void OnVolume(double volume) {}
+ virtual void OnVolume(double volume) OVERRIDE {}
// The client to notify when the stream is created. THIS MUST ONLY BE
// ACCESSED ON THE MAIN THREAD.
@@ -362,9 +362,9 @@ class PlatformAudioInputImpl
webkit::ppapi::PluginDelegate::PlatformAudioCommonClient* client);
// PlatformAudio implementation (called on main thread).
- virtual bool StartCapture();
- virtual bool StopCapture();
- virtual void ShutDown();
+ virtual bool StartCapture() OVERRIDE;
+ virtual bool StopCapture() OVERRIDE;
+ virtual void ShutDown() OVERRIDE;
private:
// I/O thread backends to above functions.
@@ -375,13 +375,13 @@ class PlatformAudioInputImpl
virtual void OnLowLatencyCreated(base::SharedMemoryHandle handle,
base::SyncSocket::Handle socket_handle,
- uint32 length);
+ uint32 length) OVERRIDE;
- virtual void OnVolume(double volume) {}
+ virtual void OnVolume(double volume) OVERRIDE {}
- virtual void OnStateChanged(AudioStreamState state) {}
+ virtual void OnStateChanged(AudioStreamState state) OVERRIDE {}
- virtual void OnDeviceReady(int index) {}
+ virtual void OnDeviceReady(int index) OVERRIDE {}
// The client to notify when the stream is created. THIS MUST ONLY BE
// ACCESSED ON THE MAIN THREAD.
« no previous file with comments | « no previous file | ppapi/api/trusted/ppb_audio_input_trusted_dev.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698