Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8488015: Revert 110327 - Add ChromeBrowserParts for non main parts. (Closed)

Created:
9 years, 1 month ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, Nirnimesh, John Grabowski, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, anantha, darin-cc_chromium.org, dyu1, Paweł Hajdan Jr., dennis_jeffrey, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 110327 - Add ChromeBrowserParts for non main parts. This reverts the code back to a single instance of BrowserMainParts, with auxillary parts (Gtk, Views, Aura, Touch) implemented from a new base class, ChromeBrowserParts, which has a Chrome specific interface, allowing initialization to be better subdivided. This should fix the notifications auto tests. BUG=103821 TEST=Make sure all tests and autotests run Review URL: http://codereview.chromium.org/8539038 TBR=stevenjb@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -502 lines) Patch
M chrome/browser/chrome_browser_main.h View 7 chunks +13 lines, -22 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 9 chunks +32 lines, -42 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_aura.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_aura.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_gtk.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_gtk.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_touch.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_touch.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_views.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/chrome_browser_main_extra_parts_views.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_unittest.cc View 3 chunks +19 lines, -11 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_aura.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_aura.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_gtk.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_touch.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_touch.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_views.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chrome_browser_parts_views.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +8 lines, -10 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +7 lines, -4 lines 0 comments Download
M content/browser/browser_main_loop.cc View 6 chunks +30 lines, -21 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/browser_main_parts.h View 3 chunks +10 lines, -5 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/shell_browser_main.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
cpu_(ooo_6.6-7.5)
9 years, 1 month ago (2011-11-16 21:15:35 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698