Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2356)

Unified Diff: content/public/browser/browser_main_parts.h

Issue 8488015: Revert 110327 - Add ChromeBrowserParts for non main parts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/mock_content_browser_client.cc ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_main_parts.h
===================================================================
--- content/public/browser/browser_main_parts.h (revision 110349)
+++ content/public/browser/browser_main_parts.h (working copy)
@@ -15,8 +15,9 @@
// Each stage is represented by a single BrowserMainParts method, called from
// the corresponding method in |BrowserMainLoop| (e.g., EarlyInitialization())
// which does the following:
-// - calls a method (e.g., "PreEarlyInitialization()") which implements
-// platform / tookit specific code for that stage.
+// - calls a method (e.g., "PreEarlyInitialization()") for each member of
+// |parts_|. Parts will implement platform or tookit specific code for that
+// stage.
// - calls various methods for things common to all platforms (for that stage).
// - calls a method (e.g., "PostEarlyInitialization()") for platform-specific
// code to be called after the common code.
@@ -48,6 +49,9 @@
// existing chunk which makes it longer than one or two lines, please move
// the code out into a separate method.)
//
+// There can be any number of "Parts". These should be constructed in
+// ContentBrowserClient::CreateBrowserMainParts. Each stage will be called
+// for each part in the order it was added. Destruction is in the inverse order.
class CONTENT_EXPORT BrowserMainParts {
public:
BrowserMainParts() {}
@@ -59,16 +63,17 @@
virtual void PreMainMessageLoopStart() = 0;
- virtual void PostMainMessageLoopStart() = 0;
-
// Allows an embedder to do any extra toolkit initialization.
virtual void ToolkitInitialized() = 0;
+ virtual void PostMainMessageLoopStart() = 0;
+
virtual void PreMainMessageLoopRun() = 0;
// Returns true if the message loop was run, false otherwise.
- // If this returns false, the default implementation will be run.
// May set |result_code|, which will be returned by |BrowserMain()|.
+ // If no BrowserMainParts implementations return true, the default
+ // implementation will be run.
virtual bool MainMessageLoopRun(int* result_code) = 0;
virtual void PostMainMessageLoopRun() = 0;
« no previous file with comments | « content/browser/mock_content_browser_client.cc ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698