Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/chrome_browser_main_unittest.cc

Issue 8488015: Revert 110327 - Add ChromeBrowserParts for non main parts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chrome_browser_main_linux.cc ('k') | chrome/browser/chrome_browser_parts_aura.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "chrome/browser/chrome_browser_main.h" 10 #include "chrome/browser/chrome_browser_main.h"
(...skipping 12 matching lines...) Expand all
23 protected: 23 protected:
24 TestingPrefService pref_service_; 24 TestingPrefService pref_service_;
25 CommandLine command_line_; 25 CommandLine command_line_;
26 }; 26 };
27 27
28 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_WarmestSocket) { 28 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_WarmestSocket) {
29 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "0"); 29 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "0");
30 30
31 scoped_ptr<content::MainFunctionParams> params( 31 scoped_ptr<content::MainFunctionParams> params(
32 new content::MainFunctionParams(command_line_)); 32 new content::MainFunctionParams(command_line_));
33 scoped_ptr<content::BrowserMainParts> bw( 33 ScopedVector<content::BrowserMainParts> bwv;
34 content::GetContentClient()->browser()->CreateBrowserMainParts(*params)); 34 content::GetContentClient()->browser()->CreateBrowserMainParts(
35 ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get()); 35 *params, &(bwv.get()));
36 ChromeBrowserMainParts* cbw = NULL;
37 if (bwv.size() >= 1)
38 cbw = static_cast<ChromeBrowserMainParts*>(bwv[0]);
36 EXPECT_TRUE(cbw); 39 EXPECT_TRUE(cbw);
37 if (cbw) { 40 if (cbw) {
38 cbw->WarmConnectionFieldTrial(); 41 cbw->WarmConnectionFieldTrial();
39 EXPECT_EQ(0, net::GetSocketReusePolicy()); 42 EXPECT_EQ(0, net::GetSocketReusePolicy());
40 } 43 }
41 } 44 }
42 45
43 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Random) { 46 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Random) {
44 scoped_ptr<content::MainFunctionParams> params( 47 scoped_ptr<content::MainFunctionParams> params(
45 new content::MainFunctionParams(command_line_)); 48 new content::MainFunctionParams(command_line_));
46 scoped_ptr<content::BrowserMainParts> bw( 49 ScopedVector<content::BrowserMainParts> bwv;
47 content::GetContentClient()->browser()->CreateBrowserMainParts(*params)); 50 content::GetContentClient()->browser()->CreateBrowserMainParts(
48 ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get()); 51 *params, &(bwv.get()));
52 ChromeBrowserMainParts* cbw = NULL;
53 if (bwv.size() >= 1)
54 cbw = static_cast<ChromeBrowserMainParts*>(bwv[0]);
49 EXPECT_TRUE(cbw); 55 EXPECT_TRUE(cbw);
50 if (cbw) { 56 if (cbw) {
51 const int kNumRuns = 1000; 57 const int kNumRuns = 1000;
52 for (int i = 0; i < kNumRuns; i++) { 58 for (int i = 0; i < kNumRuns; i++) {
53 cbw->WarmConnectionFieldTrial(); 59 cbw->WarmConnectionFieldTrial();
54 int val = net::GetSocketReusePolicy(); 60 int val = net::GetSocketReusePolicy();
55 EXPECT_LE(val, 2); 61 EXPECT_LE(val, 2);
56 EXPECT_GE(val, 0); 62 EXPECT_GE(val, 0);
57 } 63 }
58 } 64 }
59 } 65 }
60 66
61 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Invalid) { 67 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Invalid) {
62 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "100"); 68 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "100");
63 69
64 scoped_ptr<content::MainFunctionParams> params( 70 scoped_ptr<content::MainFunctionParams> params(
65 new content::MainFunctionParams(command_line_)); 71 new content::MainFunctionParams(command_line_));
66 // This test ends up launching a new process, and that doesn't initialize the 72 // This test ends up launching a new process, and that doesn't initialize the
67 // ContentClient interfaces. 73 // ContentClient interfaces.
68 scoped_ptr<content::BrowserMainParts> bw; 74 ScopedVector<content::BrowserMainParts> bwv;
69 if (content::GetContentClient()) { 75 if (content::GetContentClient()) {
70 bw.reset(content::GetContentClient()->browser()->CreateBrowserMainParts( 76 content::GetContentClient()->browser()->CreateBrowserMainParts(
71 *params)); 77 *params, &(bwv.get()));
72 } else { 78 } else {
73 chrome::ChromeContentBrowserClient ccbc; 79 chrome::ChromeContentBrowserClient ccbc;
74 bw.reset(ccbc.CreateBrowserMainParts(*params)); 80 ccbc.CreateBrowserMainParts(*params, &(bwv.get()));
75 } 81 }
76 ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get()); 82 ChromeBrowserMainParts* cbw = NULL;
83 if (bwv.size() >= 1)
84 cbw = static_cast<ChromeBrowserMainParts*>(bwv[0]);
77 EXPECT_TRUE(cbw); 85 EXPECT_TRUE(cbw);
78 if (cbw) { 86 if (cbw) {
79 #if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON) 87 #if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
80 EXPECT_DEATH(cbw->WarmConnectionFieldTrial(), 88 EXPECT_DEATH(cbw->WarmConnectionFieldTrial(),
81 "Not a valid socket reuse policy group"); 89 "Not a valid socket reuse policy group");
82 #else 90 #else
83 EXPECT_DEBUG_DEATH(cbw->WarmConnectionFieldTrial(), 91 EXPECT_DEBUG_DEATH(cbw->WarmConnectionFieldTrial(),
84 "Not a valid socket reuse policy group"); 92 "Not a valid socket reuse policy group");
85 #endif 93 #endif
86 } 94 }
87 } 95 }
OLDNEW
« no previous file with comments | « chrome/browser/chrome_browser_main_linux.cc ('k') | chrome/browser/chrome_browser_parts_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698