content/browser/download/download_file_manager.cc - Issue 8487002: Basic tests for DownloadUrl/DownloadUrlToFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_file_manager.cc

Issue 8487002: Basic tests for DownloadUrl/DownloadUrlToFile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed early setting of info->path to avoid assertion. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_file_manager.cc

diff --git a/content/browser/download/download_file_manager.cc b/content/browser/download/download_file_manager.cc

index 755e6e9698b6ff1d36d8a1aed60e13e31a1247cd..5700772b83729f1829ee1b088f4bbdaaf17ae6d0 100644

--- a/content/browser/download/download_file_manager.cc

+++ b/content/browser/download/download_file_manager.cc

@@ -135,9 +135,6 @@ void DownloadFileManager::StartDownload(

return;

}

- // TODO(phajdan.jr): fix the duplication of path info below.

- info->path = info->save_info.file_path;

ahendrickson 2011/11/08 06:19:58 The only effect I can see of removing this line is

manager->CreateDownloadItem(info, request_handle);

bool hash_needed = manager->delegate()->GenerateFileHash();