Basic tests for DownloadUrl/DownloadUrlToFile.

content/browser/download/download_file_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_file_manager.h"
 
 #include <set>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 117 matching lines @@
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(info);
 
   DownloadManager* manager = request_handle.GetDownloadManager();
   if (!manager) {
     request_handle.CancelRequest();
     delete info;
     return;
   }
 
-  // TODO(phajdan.jr): fix the duplication of path info below.
-  info->path = info->save_info.file_path;

[ahendrickson, 2011/11/08 06:19:58]

The only effect I can see of removing this line is that potentially these
functions:

GetTemporaryDownloads()
GetAllDownloads()

will return a different result if called before ContinueDownloadWithPath().

-
   manager->CreateDownloadItem(info, request_handle);
   bool hash_needed = manager->delegate()->GenerateFileHash();
 
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
       base::Bind(&DownloadFileManager::CreateDownloadFile, this,
                  info, request_handle, make_scoped_refptr(manager),
                  hash_needed));
 }
 
 // We don't forward an update to the UI thread here, since we want to throttle
@@ skipping 272 matching lines @@
            << " id = " << global_id
            << " download_file = " << download_file->DebugString();
 
   downloads_.erase(global_id);
 
   delete download_file;
 
   if (downloads_.empty())
     StopUpdateTimer();
 }