chrome/browser/download/download_test_observer.cc - Issue 8487002: Basic tests for DownloadUrl/DownloadUrlToFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_test_observer.cc

Issue 8487002: Basic tests for DownloadUrl/DownloadUrlToFile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed early setting of info->path to avoid assertion. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_test_observer.cc

diff --git a/chrome/browser/download/download_test_observer.cc b/chrome/browser/download/download_test_observer.cc

index c60f3746b2b632186f97105b85b88b9ac3cc85dd..e60eb078d50bb6bdf3e949a1c86d4a8df6657549 100644

--- a/chrome/browser/download/download_test_observer.cc

+++ b/chrome/browser/download/download_test_observer.cc

@@ -142,6 +142,9 @@ void DownloadTestObserver::ModelChanged() {

// (done by |OnDownloadUpdated()|).

std::vector<DownloadItem*> downloads;

download_manager_->GetAllDownloads(FilePath(), &downloads);

+ // As a test class, we're generally interested in whatever's there,

+ // so we include temporary downloads.

+ download_manager_->GetTemporaryDownloads(FilePath(), &downloads);

for (std::vector<DownloadItem*>::iterator it = downloads.begin();

it != downloads.end(); ++it) {