Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8469015: Switch BackgroundContents to use TabContents instead of RenderViewHost. (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, yoshiki+watch_chromium.org, ajwong+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Switch BackgroundContents to use TabContents instead of RenderViewHost. BUG=99698, 98934 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109661

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : Change TabContentsObserver virtual methods to not clash with TabContentsDelegate #

Patch Set 4 : fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -337 lines) Patch
M chrome/browser/autofill/autofill_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 2 3 3 chunks +18 lines, -94 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 2 3 4 chunks +34 lines, -164 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_finder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_finder.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 4 chunks +15 lines, -19 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/intents/intent_injector.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/intents/intent_injector.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 1 month ago (2011-11-10 23:56:23 UTC) #1
Andrew T Wilson (Slow)
9 years, 1 month ago (2011-11-11 18:28:07 UTC) #2 
LGTM - this is a great change. Thanks again for tackling this!

Powered by Google App Engine
This is Rietveld 408576698