chrome/browser/tabs/tab_finder.cc - Issue 8469015: Switch BackgroundContents to use TabContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tabs/tab_finder.cc

Issue 8469015: Switch BackgroundContents to use TabContents instead of RenderViewHost. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix unittest Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tabs/tab_finder.cc

===================================================================

--- chrome/browser/tabs/tab_finder.cc (revision 109469)

+++ chrome/browser/tabs/tab_finder.cc (working copy)

@@ -32,7 +32,7 @@

TabContents* tab_contents() { return TabContentsObserver::tab_contents(); }

// TabContentsObserver overrides:

- virtual void DidNavigateAnyFramePostCommit(

+ virtual void DidNavigateAnyFrame(

const content::LoadCommittedDetails& details,

const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE;

virtual void TabContentsDestroyed(TabContents* tab) OVERRIDE;

@@ -53,10 +53,10 @@

TabFinder::TabContentsObserverImpl::~TabContentsObserverImpl() {

}

-void TabFinder::TabContentsObserverImpl::DidNavigateAnyFramePostCommit(

+void TabFinder::TabContentsObserverImpl::DidNavigateAnyFrame(

const content::LoadCommittedDetails& details,

const ViewHostMsg_FrameNavigate_Params& params) {

- finder_->DidNavigateAnyFramePostCommit(tab_contents(), details, params);

+ finder_->DidNavigateAnyFrame(tab_contents(), details, params);

}

void TabFinder::TabContentsObserverImpl::TabContentsDestroyed(

@@ -130,7 +130,7 @@

STLDeleteElements(&tab_contents_observers_);

}

-void TabFinder::DidNavigateAnyFramePostCommit(

+void TabFinder::DidNavigateAnyFrame(

TabContents* source,

const content::LoadCommittedDetails& details,

const ViewHostMsg_FrameNavigate_Params& params) {